Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 19 Mar 2021

3:39 pm

Sean Nash

More
4dbeaf1
changed 2 files
develop_1-61

Fixed saline bolus safety check. Will add changes to dev branch.

- -2
- +2
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -2
- +4
/firmware/App/Services/Interrupts.c
- History
- Source
- Diff
/firmware/App/Services/Interrupts.c

2:32 pm

Quang Nguyen <qnguyen@diality.com>

More
eae4504
changed 3 files
develop_1-61

Merge branch 'DEN-7091-pre-treatment-mode' into develop

- -2
- +6
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -2
- +0
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -0
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

2:32 pm

Quang Nguyen <qnguyen@diality.com>

More
ac636de
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 360 more HD-DEN-7091-1

DEN-7091: Added build switch to disable battery comm

- -0
- +3
/firmware/App/Drivers/Battery.c
- History
- Source
- Diff
/firmware/App/Drivers/Battery.c
- -0
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

12:20 pm

Sean Nash

More
ee2af47
changed 0 files
develop_1-61

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

10:50 am

Sean Nash

More
HD-DEN-6453-1
Closed

10:41 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

qnguyen (deleted user)

More
Re: HD-DEN-7091-1
replied to Sean Nash

Make it private function to this module and call from DG monitor function.

Make it private function to this module and call from DG monitor function.

10:40 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Dara Navaei , qnguyen (deleted user) and pmontazemi (deleted user)

More
HD-DEN-6453-1
finished reviewing

10:36 am

qnguyen (deleted user)

More
Re: HD-DEN-7117-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen (deleted user)

More
Re: HD-DEN-7117-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen (deleted user)

More
Re: HD-DEN-7117-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: HD-DEN-6453-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

More
111d91e
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 362 more HD-DEN-6453-1 HD-DEN-7117-1

DEN-6453: Addressed code review feedback.

- -1
- +1
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c

10:01 am

Sean Nash

More
Re: HD-DEN-6453-1
replied to qnguyen (deleted user)

Removed comment.

Removed comment.

9:58 am

Sean Nash

More
Re: HD-DEN-7117-1
replied to qnguyen (deleted user)

UF off and complete states are going to be removed. Removed case handlers and handler functions. Keeping enums until UI is updated to not use them.

UF off and complete states are going to be removed. Removed case handlers and handler functions. Keeping enums until UI is updated to not use them.

9:57 am

Quang Nguyen <qnguyen@diality.com>

More
aaee82d
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 360 more HD-DEN-7091-1

DEN-7091: Added DG restart check to DG interface monitor

- -2
- +6
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -2
- +0
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -3
- +0
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c

9:57 am

Sean Nash

More
e22cea1
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-DEN-7117-1

DEN-7117: Addressed code review feedback.

- -46
- +2
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -0
- +108
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c

9:56 am

Sean Nash

More
Re: HD-DEN-7117-1
replied to qnguyen (deleted user)

Done.

Done.

9:44 am

Sean Nash

More
Re: HD-DEN-7117-1
replied to qnguyen (deleted user)

Done.

Done.

9:43 am

qnguyen (deleted user)

More
Re: HD-DEN-6453-1
commented on review

Looks like the function has 250 ms persistence, do we need the TODO anymore?

Looks like the function has 250 ms persistence, do we need the TODO anymore?

9:15 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

There is a DG monitor function near top of this module. I recommend calling it from there. TaskGeneral should only be calling very high level functions.

There is a DG monitor function near top of this module. I recommend calling it from there. TaskGeneral should only be calling very high level functions.

9:11 am

Sean Nash

More
5483f23
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 362 more HD-DEN-6453-1

DEN-6453: Fixed merge issues from staging.

- -70
- +69
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c

Thursday 18 Mar 2021

11:05 pm

Sean Nash

More
1499099
changed 0 files
develop_1-61

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

11:05 pm

Sean Nash

More
32f48ac
changed 3 files
develop_1-61

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

- -41
- +0
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -1
- +0
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -2
- +2
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

11:05 pm

Sean Nash

More
6811f02
changed 4 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-DEN-7117-1

DEN-7117: Removed small load cell filter - redundant with larger DG filter now.

- -41
- +0
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -1
- +0
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -1
- +2
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -2
- +2
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

8:03 pm

Quang Nguyen <qnguyen@diality.com>

More
5cd3f0f
changed 0 files
develop_1-61

Merge branch 'DEN-7091-pre-treatment-mode' into develop

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-12 12:26 -0800