hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
10:29 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code reviews

Options
    • -6
    • +6
    /firmware/App/Modes/ConsumableSelfTest.c
    • -7
    • +20
    /firmware/App/Modes/ModePreTreat.c
    • -16
    • +15
    /firmware/App/Modes/SampleWater.c
    • -1
    • +1
    /firmware/App/Modes/SampleWater.h
10:20 am

Sean Nash

If DG somehow gets ahead of HD here, I worry we will get stuck. Consider second condition with "getDGSubMode() >= DG_FILL_MODE_STATE_BICARB_PUMP_CHECK". Same for states below.

If DG somehow gets ahead of HD here, I worry we will get stuck. Consider second condition with "getDGSubMode() >= DG_FILL_MODE_STATE_BICARB_PUMP_CHECK". Same for states below.

10:11 am

Sean Nash

When using build switches, convention is to put the normal code first. So use #ifndef and swap the statements below.

When using build switches, convention is to put the normal code first. So use #ifndef and swap the statements below.

10:09 am

qnguyen  (deleted user)

When the sample water result entered by the user, HD will command DG to end water sampling mode and go back to standby idle state.

When the sample water result entered by the user, HD will command DG to end water sampling mode and go back to standby idle state.

10:08 am

Dara Navaei

10:07 am

Sean Nash

Why is bad sample result handled here and good sample result handled in pre-treatment mode?

Why is bad sample result handled here and good sample result handled in pre-treatment mode?

10:05 am

Sean Nash

How will DG standby get back to idle state from flush idle state? Where does that happen?

How will DG standby get back to idle state from flush idle state? Where does that happen?

10:04 am

Sean Nash

Use set dialysate temp from treatment parameters for trimmer heater target temp. Add 2 degrees for primary heater target temp.

Use set dialysate temp from treatment parameters for trimmer heater target temp. Add 2 degrees for primary heater target temp.

9:58 am

Sean Nash

Add fault.

Add fault.

9:57 am

Sean Nash

Consider renaming this to sampleWaterResultEntered to clarify its purpose.

Consider renaming this to sampleWaterResultEntered to clarify its purpose.

Sunday 21 Mar 2021
7:40 pm

qnguyen  (deleted user)

Should we check here if calibration data is valid?

Should we check here if calibration data is valid?

4:59 pm

qnguyen  (deleted user)

Where is this getHDFlowSensorsCalibrationRecord function located? Is it part of fwcommon changes? If yes, please add to code review.

Where is this getHDFlowSensorsCalibrationRecord function located? Is it part of fwcommon changes? If yes, please add to code review.

4:57 pm

qnguyen  (deleted user)

Remove this typedef. It is defined in common repo.

Remove this typedef. It is defined in common repo.

4:56 pm

qnguyen  (deleted user)

Remove this case. Its obsolete.

Remove this case. Its obsolete.

4:54 pm

qnguyen  (deleted user)

Comment's first letter needs to be capitalized.

Comment's first letter needs to be capitalized.

4:52 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added timeout to i2c receive

Options
    • -18
    • +60
    /firmware/App/Drivers/Battery.c
Friday 19 Mar 2021
11:41 pm

Sean Nash

DEN-7117: Fixed volume safety check for rinseback and blood prime. Added more interface functions to syringe pump driver.

Options
    • -1
    • +37
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +2
    /firmware/App/Controllers/SyringePump.h
    • -1
    • +0
    /firmware/App/HDCommon.h
    • -2
    • +2
    /firmware/App/Modes/BloodPrime.c
    • -7
    • +5
    /firmware/App/Modes/Dialysis.c
    • -3
    • +3
    /firmware/App/Modes/Rinseback.c
11:10 pm

Dara Navaei

3:58 pm

Sean Nash

Fixed merge conflicts.

Options
3:56 pm

Sean Nash

DEN-7117: Fix saline bolus safety check.

Options
    • -2
    • +2
    /firmware/App/Modes/Dialysis.c
    • -4
    • +6
    /firmware/App/Services/Interrupts.c
3:40 pm

Sean Nash

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
3:39 pm

Sean Nash

Fixed saline bolus safety check. Will add changes to dev branch.

Options
    • -2
    • +2
    /firmware/App/Modes/Dialysis.c
    • -2
    • +4
    /firmware/App/Services/Interrupts.c
2:32 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-7091-pre-treatment-mode' into develop

Options
    • -2
    • +6
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +0
    /firmware/App/Controllers/DGInterface.h
    • -0
    • +1
    /firmware/App/HDCommon.h
2:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added build switch to disable battery comm

Options
    • -0
    • +3
    /firmware/App/Drivers/Battery.c
    • -0
    • +1
    /firmware/App/HDCommon.h
12:20 pm

Sean Nash

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

Options
10:50 am

Sean Nash

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

qnguyen  (deleted user)

Make it private function to this module and call from DG monitor function.

Make it private function to this module and call from DG monitor function.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.