hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7091: Addressed code review

Wrong valve state. Fixed.

Wrong valve state. Fixed.

Fixed.

Fixed.

Fixed. Now the BP pump should be off when the test is done.

Fixed. Now the BP pump should be off when the test is done.

The valves were not correct. It should be back to the previous state when the BP is off. The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP. Added 2 se...

The valves were not correct. It should be back to the previous state when the BP is off.
The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP.
Added 2 seconds time out for pressure to be normalized.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement. Removed the check for settle time in second displacement setup.

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement.
Removed the check for settle time in second displacement setup.

Probably should be fabs() here. And change 1 to 1.0.

Probably should be fabs() here. And change 1 to 1.0.

Probably should be fabs() here. and change 1 to 1.0.

Probably should be fabs() here. and change 1 to 1.0.

Why fabs() here?

Why fabs() here?

Should set settleStartTime here.

Should set settleStartTime here.

Pressure should be float. Add .0 to end of value.

Pressure should be float. Add .0 to end of value.

These volumes (4 of them) should be floats so we should add .0 to end of set value.

These volumes (4 of them) should be floats so we should add .0 to end of set value.

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

Should be 0.0.

Should be 0.0.

Valve positions same so pull out of if-else.

Valve positions same so pull out of if-else.

This test is more about the cartridge should be dry. Sensors' faults should be part of POST or no cartridge self-tests.

This test is more about the cartridge should be dry.
Sensors' faults should be part of POST or no cartridge self-tests.

This test is more about the cartridge should be dry. Sensors' faults should be part of POST or no cartridge self-tests.

This test is more about the cartridge should be dry.
Sensors' faults should be part of POST or no cartridge self-tests.

Shouldn't we turn BP off when we're done using it for test?

Shouldn't we turn BP off when we're done using it for test?

Is use of fabs() here appropriate? Do we really not care which pressure is larger? It looks like previous readings are with VBA/VBV closed and BP off while current readings are with BP on and valve...

Is use of fabs() here appropriate? Do we really not care which pressure is larger? It looks like previous readings are with VBA/VBV closed and BP off while current readings are with BP on and valves open.

Air trap was already closed - why closing it again?

Air trap was already closed - why closing it again?

Add blank line here. Also add comment for these if statements to describe the conditions. Looks like first if for when to end the test and second if is pass/fail criteria.

Add blank line here.
Also add comment for these if statements to describe the conditions. Looks like first if for when to end the test and second if is pass/fail criteria.