hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5980 addressed a code review comment

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove extra line.

Remove extra line.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-5980 addressed code review comments and merged staging

    • -31
    • +28
    /firmware/App/Controllers/BloodFlow.c
    • -28
    • +22
    /firmware/App/Controllers/DialInFlow.c
    • -122
    • +453
    /firmware/App/Modes/ModeTreatment.c
    • -0
    • +27
    /firmware/App/Services/SystemComm.c
Done

Done

Done

Done

It is a Diality board but it is treated as an eval board since there is nothing attached to it.

It is a Diality board but it is treated as an eval board since there is nothing attached to it.

Rename this. This build switch for was eval board. No longer used.

Rename this. This build switch for was eval board. No longer used.

Just delete this case.

Just delete this case.

Are you really running this on an eval board? I removed this build switch a while back as nobody was using it anymore.

Are you really running this on an eval board? I removed this build switch a while back as nobody was using it anymore.

DEN-7117: Addressed code review feedback.

    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
Agreed. Tricky because delta is signed, but it works the way I need it to.

Agreed. Tricky because delta is signed, but it works the way I need it to.

Added TODO for now.

Added TODO for now.

DEN-5980 addressed code review comments

    • -9
    • +0
    /firmware/App/Controllers/DGInterface.h
    • -12
    • +12
    /firmware/App/Modes/ModeTreatment.c
    • -10
    • +15
    /firmware/App/Tasks/TaskGeneral.c
fwcommon had to be updated with latest changes. It is un-commented.

fwcommon had to be updated with latest changes. It is un-commented.

fwcommon had to be updated with latest changes. They are un-commented.

fwcommon had to be updated with latest changes. They are un-commented.

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

I am not sure. I un-commented it.

I am not sure. I un-commented it.

Done.

Done.

Done

Done