Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 24 Mar 2021

9:11 am

Dara Navaei

More
eda59c3
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 360 more HD-DEN-5980-1

DEN-5980 addressed code review comments

- -1
- +1
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

9:10 am

Dara Navaei

More
Re: HD-DEN-5980-1
replied to Sean Nash

Done.

Done.

8:53 am

Dara Navaei

More
Re: HD-DEN-5980-1
replied to qnguyen (deleted user)

Done.

Done.

8:48 am

Dara Navaei

More
Re: HD-DEN-5980-1
replied to qnguyen (deleted user)

Done.

Done.

8:47 am

Dara Navaei

More
Re: HD-DEN-5980-1
replied to qnguyen (deleted user)

Done.

Done.

Tuesday 23 Mar 2021

4:58 pm

Peman Montazemi <pmontazemi@diality.com>

More
7d229e6
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 358 more HD-DEN-7395-1

DEN-7395: Resolved merge issues

- -23
- +0
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -269
- +0
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -1
- +0
/firmware/App/Modes/SelfTests.h
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.h

4:09 pm

Peman Montazemi <pmontazemi@diality.com>

More
033f3e4
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 358 more HD-DEN-7395-1

DEN-7395: Added handle test implementation for Blood Leak Detector driver overrides

- -0
- +6
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

4:05 pm

pmontazemi (deleted user)

More
HD-DEN-7395-1
started review

HD-DEN-7395_HD Blood Leak Detector

HD-DEN-7395_HD Blood Leak Detector

2:47 pm

Sean Nash

More
2c85a64
changed 5 files
develop_1-61

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

- -8
- +1
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -2
- +2
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -1
- +1
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -1
- +0
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h
- -2
- +2
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

2:47 pm

Sean Nash

More
174c9ba
changed 4 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-DEN-7117-1 HD-DEN-7091-1 HD-DEN-7347-1

DEN-7117: Addressed code review feedback.

- -2
- +2
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -1
- +1
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -1
- +1
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -2
- +2
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

2:05 pm

Sean Nash

More
Re: HD-DEN-7117-1
replied to pmontazemi (deleted user)

Done.

Done.

2:02 pm

Sean Nash

More
Re: HD-DEN-7117-1
replied to pmontazemi (deleted user)

It is volts. Everywhere else we use abbreviated units of measure as suffix (e.g. _ML).

It is volts. Everywhere else we use abbreviated units of measure as suffix (e.g. _ML).

1:25 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7117-1
commented on review

What does the V stand for in the name of this function? Can we be more explicit? If voltage, then "Volt".

What does the V stand for in the name of this function? Can we be more explicit? If voltage, then "Volt".

1:11 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7117-1
commented on review

Are we getting load cell weight in other units somewhere else? If not, I would suggest defining the units in the function header and removing it from the name of the function.

Are we getting load cell weight in other units somewhere else? If not, I would suggest defining the units in the function header and removing it from the name of the function.

11:45 am

Quang Nguyen <qnguyen@diality.com>

More
07e0fa7
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 357 more HD-DEN-7347-1

DEN-7347: Updated de-prime operation

- -150
- +62
/firmware/App/Modes/ModePostTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.c
- -64
- +2
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:17 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:14 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:14 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:14 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:13 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:13 am

Sean Nash

More
Re: HD-DEN-7091-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 00:50 -0700