hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Mar 2021
2:30 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added one second wait time in sub-mode complete state

Options
    • -13
    • +35
    /firmware/App/Modes/ModePreTreat.c
    • -15
    • +0
    /firmware/App/Modes/Prime.c
    • -1
    • +0
    /firmware/App/Modes/Prime.h
    • -33
    • +2
    /firmware/App/Modes/SelfTests.c
    • -2
    • +0
    /firmware/App/Modes/SelfTests.h
2:09 pm

pmontazemi  (deleted user)

Add TODO for all commented lines below.

Add TODO for all commented lines below.

2:07 pm

pmontazemi  (deleted user)

Add TODO.

Add TODO.

2:05 pm

pmontazemi  (deleted user)

Add TODO.

Add TODO.

2:05 pm

pmontazemi  (deleted user)

Add TODO to commented line.

Add TODO to commented line.

2:05 pm

pmontazemi  (deleted user)

Add TODO to commented lines.

Add TODO to commented lines.

2:04 pm

pmontazemi  (deleted user)

Add TODO.

Add TODO.

2:03 pm

pmontazemi  (deleted user)

Add TODO.

Add TODO.

2:03 pm

pmontazemi  (deleted user)

Add TODO.

Add TODO.

2:01 pm

pmontazemi  (deleted user)

Add TODO to commented lines.

Add TODO to commented lines.

2:00 pm

pmontazemi  (deleted user)

Add TODO to commented line.

Add TODO to commented line.

11:49 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added treatment start message handler

Options
    • -89
    • +5
    /firmware/App/Modes/Dialysis.c
    • -7
    • +5
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -6
    • +16
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.h
    • -1
    • +4
    /firmware/App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -1
    • +1
    /firmware/App/Modes/Prime.h
    • -0
    • +1
    /firmware/App/Modes/SelfTests.c
    • -3
    • +7
    /firmware/App/Services/SystemComm.c
    • -30
    • +43
    /firmware/App/Services/SystemCommMessages.c
    • -4
    • +10
    /firmware/App/Services/SystemCommMessages.h
10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:27 am

qnguyen  (deleted user)

This was temporary before a blood leak driver. Delete if not needed.

This was temporary before a blood leak driver. Delete if not needed.

10:27 am

qnguyen  (deleted user)

This was temporary before a blood leak driver. Delete if not needed.

This was temporary before a blood leak driver. Delete if not needed.

10:25 am

qnguyen  (deleted user)

Why this one is deleted?

Why this one is deleted?

10:22 am

Sean Nash

Do we need a get function for determining if/when zero is done? And another for determining if self-test passed/failed?

Do we need a get function for determining if/when zero is done? And another for determining if self-test passed/failed?

10:22 am

qnguyen  (deleted user)

Remove this. No need to add if there are no parameters.

Remove this. No need to add if there are no parameters.

10:21 am

Sean Nash

Alarm if in patient connected mode/sub-mode, fault if not.

Alarm if in patient connected mode/sub-mode, fault if not.

9:52 am

Sean Nash

Check should only be done if not doing self-test. If doing self-test, a different (opposite) check should be done (if blood not detected within TBD ms, fault).

Check should only be done if not doing self-test. If doing self-test, a different (opposite) check should be done (if blood not detected within TBD ms, fault).

9:46 am

Sean Nash

What about functions for 1) getting zero status, 2) setting sensor config (normal, self-test, zero)?

What about functions for 1) getting zero status, 2) setting sensor config (normal, self-test, zero)?

9:43 am

Sean Nash

Should be 0x1000? And shouldn't we add another mask for blood leak zero state (0x2000)?

Should be 0x1000?
And shouldn't we add another mask for blood leak zero state (0x2000)?

9:18 am

Sean Nash

We should consider adding Dialin options to zero sensor and initiate self-test.

We should consider adding Dialin options to zero sensor and initiate self-test.

9:17 am

Sean Nash

Move both leak monitors to monitors section above.

Move both leak monitors to monitors section above.

9:17 am

Sean Nash

These need to be called from switch statement at bottom of SystemComm.c.

These need to be called from switch statement at bottom of SystemComm.c.

9:11 am

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c