hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 01 Apr 2021
3:44 pm

Dara Navaei

DEN-5980 uncommented a line of code

Options
    • -2
    • +1
    /firmware/App/Tasks/TaskGeneral.c
3:40 pm

Dara Navaei

DEN-5980 tested the code

Options
    • -1
    • +2
    /firmware/App/HDCommon.h
    • -3
    • +8
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +5
    /firmware/App/Tasks/TaskGeneral.c
    • -0
    • +1
    /firmware/source/sys_main.c
10:43 am

pmontazemi  (deleted user)

Replace 0x40 with constant and define it at beginning of *.c file.

Replace 0x40 with constant and define it at beginning of *.c file.

10:43 am

pmontazemi  (deleted user)

Replace 0x3F with constant and define it at beginning of *.c file.

Replace 0x3F with constant and define it at beginning of *.c file.

10:43 am

pmontazemi  (deleted user)

Replace 0x80 with constant and define it at beginning of *.c file.

Replace 0x80 with constant and define it at beginning of *.c file.

10:42 am

pmontazemi  (deleted user)

Use 10 instead of ten (easier to track and compare).

Use 10 instead of ten (easier to track and compare).

10:42 am

pmontazemi  (deleted user)

Use 5 instead of five (easier to track and compare).

Use 5 instead of five (easier to track and compare).

9:45 am

qnguyen  (deleted user)

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold. This function makes sure all ...

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold.
This function makes sure all of them are below the threshold.

9:14 am

Sean Nash

I think memset is in string.h. Should you add a #include <string.h> at top of module?

I think memset is in string.h. Should you add a #include <string.h> at top of module?

9:11 am

Sean Nash

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?

8:55 am

Sean Nash

Was this function temporary too?

Was this function temporary too?

8:50 am

Sean Nash

I think this should be an and because of the "whichever is greater" part of the condition.

I think this should be an and because of the "whichever is greater" part of the condition.

8:49 am

Sean Nash

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to...

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to alarm on a percentage basis. Likewise, if delta is > 0.1 mL but error is < 5%, no alarm.

Wednesday 31 Mar 2021
6:02 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Added description to post-treatment mode module

Options
    • -0
    • +2
    /firmware/App/Modes/ModePostTreat.c
    • -2
    • +4
    /firmware/App/Modes/ModePostTreat.h
Tuesday 30 Mar 2021
10:01 pm

Sean Nash

DEN-7117: Doxygen updates. Added TODOs for not yet implemented self-tests for syringe pump driver.

Options
    • -25
    • +62
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/Modes/Dialysis.c
    • -2
    • +7
    /firmware/App/Services/FPGA.c
    • -2
    • +9
    /firmware/App/Services/FPGA.h
Monday 29 Mar 2021
10:20 pm

qnguyen  (deleted user)

Should this be an or?

Should this be an or?

10:20 pm

qnguyen  (deleted user)

Should this be an or?

Should this be an or?

9:55 pm

Dara Navaei

The above line has been removed.

The above line has been removed.

9:53 pm

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -2
    • +4
    /firmware/App/Modes/ModePreTreat.c
9:40 pm

Dara Navaei

DEN-5980 resolved merge conflicts and addressed the code review comments

Options
    • -3
    • +3
    /firmware/App/Controllers/BloodFlow.c
    • -3
    • +3
    /firmware/App/Controllers/DialInFlow.c
    • -88
    • +5
    /firmware/App/Modes/Dialysis.c
    • -63
    • +3
    /firmware/App/Modes/SelfTests.c
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
9:40 pm

Dara Navaei

Done.

Done.

9:39 pm

Dara Navaei

This function has been removed.

This function has been removed.

9:39 pm

Dara Navaei

This function has been removed.

This function has been removed.

9:39 pm

Dara Navaei

This function has been removed.

This function has been removed.

2:17 pm

Sean Nash

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

Options
1:24 pm

Sean Nash

DEN-7117: minor fix to treatment restart when Heparin is paused.

Options
    • -1
    • +1
    /firmware/App/Modes/Dialysis.c
10:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Dara Navaei

It will be addressed in the future stories.

It will be addressed in the future stories.

10:02 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Send UI treatment log data

Options
    • -0
    • +8
    /firmware/App/Modes/ModePostTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModePostTreat.h
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -0
    • +24
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +5
    /firmware/App/Services/SystemCommMessages.h
9:51 am

Sean Nash

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

Options