hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 25 Jul 2021
4:10 pm

Dara Navaei

HD-DEN-9054_DG HD Switches
HD-DEN-9054_DG HD Switches
Saturday 24 Jul 2021
4:06 pm

Dara Navaei

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

3:54 pm

Dara Navaei

Do we not need a battery remaining percent override function for testing?

Do we not need a battery remaining percent override function for testing?

3:51 pm

Dara Navaei

The name of the function does not match with the actual name.

The name of the function does not match with the actual name.

3:49 pm

Dara Navaei

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

3:34 pm

Dara Navaei

How do you get the status of the battery charge in the self test before you check the whether it is in range?

How do you get the status of the battery charge in the self test before you check the whether it is in range?

3:28 pm

Dara Navaei

I recommend to explicitly name the input and output variables.

I recommend to explicitly name the input and output variables.

3:26 pm

Dara Navaei

Reverse the order of the condition.

Reverse the order of the condition.

3:25 pm

Dara Navaei

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Wednesday 21 Jul 2021
10:26 pm

qnguyen  (deleted user)

HD-DEN-8679_HD Dev Treatment Log
HD-DEN-8679_HD Dev Treatment Log
Wednesday 07 Jul 2021
5:21 pm

Dara Navaei

10:47 am

qnguyen  (deleted user) and Sean Nash

10:45 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 06 Jul 2021
10:02 pm

Dara Navaei

I will address this comment in DEN-9054 (switches) branch.

I will address this comment in DEN-9054 (switches) branch.

Monday 05 Jul 2021
7:27 pm

Dara Navaei

Done

Done

Sunday 04 Jul 2021
2:20 pm

Dara Navaei

I had a similar function for this.

I had a similar function for this.

Friday 02 Jul 2021
9:59 am

qnguyen  (deleted user)

Should we rename this message ID? The name does not seems to match the broadcast function.

Should we rename this message ID? The name does not seems to match the broadcast function.

Thursday 01 Jul 2021
11:23 am

Sean Nash

Why deleted?

Why deleted?

9:03 am

pmontazemi  (deleted user)

9:02 am

Dara Navaei

Done

Done

9:00 am

Dara Navaei

The #ifdefs are for making sure NV POST and all the other POSTs that necessary like the HD valves are done but the rest are skipped.

The #ifdefs are for making sure NV POST and all the other POSTs that necessary like the HD valves are done but the rest are skipped.

8:58 am

Dara Navaei

Done

Done

Monday 28 Jun 2021
11:16 am

qnguyen  (deleted user)

Remove this one. This has been handled at line 1679.

Remove this one. This has been handled at line 1679.

10:25 am

qnguyen  (deleted user)

This resets any previous command response that has not been processed for this specific command.

This resets any previous command response that has not been processed for this specific command.

8:57 am

Sean Nash

Why do all of these POST tests have these #ifdefs? They don't appear to have anything to do with NV POST.

Why do all of these POST tests have these #ifdefs? They don't appear to have anything to do with NV POST.