hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8886: second local merge from staging. Fixed merge conflicts.

    • -0
    • +20
    /firmware/App/Services/SystemComm.c
DEN-8886: Fixed bug DEN-9827.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7802: Disabled battery charge monitor when battery comm disabled

DEN-8886: Addressed code review comments.

    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
Done.

Done.

Fixed.

Fixed.

Fixed.

Fixed.

Common.h includes TestSupport.h.

Common.h includes TestSupport.h.

Added.

Added.

Changed to match your implementation.

Changed to match your implementation.

Usually. But this function is called by AlarmMgmt (not really a h/w driver) so I kept the conversion at FPGA level to keep it low level.

Usually. But this function is called by AlarmMgmt (not really a h/w driver) so I kept the conversion at FPGA level to keep it low level.

Fixed.

Fixed.

Done.

Done.

Done.

Done.

Please mention the usage of this include.

Please mention the usage of this include.

Please add the PN and the manufacturer of the sensors.

Please add the PN and the manufacturer of the sensors.

The brief does not match with what the function does.

The brief does not match with what the function does.

Was it not decided to just get the FPGA counts and then do the conversion into the driver that calls the FPGA function?

Was it not decided to just get the FPGA counts and then do the conversion into the driver that calls the FPGA function?