hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

DEN-11114: Reset BP rotor count before each treatment starts. Allow BP rotor count override to work even if WORN_CARTRIDGE build flag is enabled.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Disabled watchdog and safety shutdown POST tests for unit 2.

    • -9
    • +27
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.h
    • -6
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
DEN-11114: Added build switch to disable watchdog and safety shutdown POST tests.

    • -0
    • +4
    /firmware/App/Drivers/SafetyShutdown.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.h
    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.h
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
  1. … 57 more files in changeset.
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-9906: Addressed code review feedback.

    • -4
    • +0
    /firmware/App/Controllers/DialInFlow.c
    • -4
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -11
    • +11
    /firmware/App/Controllers/Voltages.c
Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Removed.

Removed.

Adjust the space before the equal signs.

Adjust the space before the equal signs.

I adjusted spaces "before" the equal sign.

I adjusted spaces "before" the equal sign.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule. If you think it should be added to our standard, let's discuss.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule.
If you think it should be added to our standard, let's discuss.

Added comment.

Added comment.