hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yes, we could use a single variable as the start time in all the pre-treatment states

Yes, we could use a single variable as the start time in all the pre-treatment states

Replaced "loadcellSteadyVolumeStartTime" with "steadyVolumeSamplingStartTime"

Replaced "loadcellSteadyVolumeStartTime" with "steadyVolumeSamplingStartTime"

Done

Done

Done

Done

No, loadcellSteadyVolumeStartTime was last set when the primeDialysateDialyzerTimeLimit has just expired.

No, loadcellSteadyVolumeStartTime was last set when the primeDialysateDialyzerTimeLimit has just expired.

Done

Done

Done

Done

Done.

Done.

This start time probably needs a new name to better describe what it's doing.

This start time probably needs a new name to better describe what it's doing.

Recommend just setting up pumps and valves in this function rather than calling another function.

Recommend just setting up pumps and valves in this function rather than calling another function.

Add blank line between declarations and code.

Add blank line between declarations and code.

This start time was last set in setup function - quite some time ago. So this will have immediately timed out the first time we get here. I think this still works though.

This start time was last set in setup function - quite some time ago. So this will have immediately timed out the first time we get here. I think this still works though.

If skipping priming, would we even get here?

If skipping priming, would we even get here?

Please put declarations at top of scope (i.e. just below the '{' above).

Please put declarations at top of scope (i.e. just below the '{' above).

Fixed.

Fixed.

Replaced by primeDialysateDialyzerTimeLimit because this variable is dynamic and based on the type of dialyzer.

Replaced by primeDialysateDialyzerTimeLimit because this variable is dynamic and based on the type of dialyzer.

Add blank line between these two lines.

Add blank line between these two lines.

Add blank line between these lines.

Add blank line between these lines.

Do we need separate start time variables? These are not used at same time - consider consolidating into a single variable.

Do we need separate start time variables? These are not used at same time - consider consolidating into a single variable.

Should be 120 mL divided by 300 mL/min times 60 sec/min = 24 seconds.

Should be 120 mL divided by 300 mL/min times 60 sec/min = 24 seconds.

Why is this commented out?

Why is this commented out?

HD-DEN-10602_UI Dev Add Patient ID Pre Treatment
HD-DEN-10602_UI Dev Add Patient ID Pre Treatment
Updated this comment to "Currently, we use 50.0 mL for testing. Remove this comment and replace 50.0 with 10.0 before merge to develop branch"

Updated this comment to
"Currently, we use 50.0 mL for testing. Remove this comment and replace 50.0 with 10.0 before merge to develop branch"

Fixed.

Fixed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.