hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Shouldn't this include be in TaskGeneral.c?

Shouldn't this include be in TaskGeneral.c?

Is the commented test code still needed?

Is the commented test code still needed?

Venous pressure does not have an error count. Is it needed?

Venous pressure does not have an error count. Is it needed?

Do we want to keep this commented out defs?

Do we want to keep this commented out defs?

Should 300 be a magic number?

Should 300 be a magic number?

Should 300 be a magic number?

Should 300 be a magic number?

There are no changes in this file and its not a new file.

There are no changes in this file and its not a new file.

Did we ever get clarification on these threshold values?

Did we ever get clarification on these threshold values?

Is this supposed to be assigned to zero? it is unlike the other variables that have been changed

Is this supposed to be assigned to zero? it is unlike the other variables that have been changed

based on the struct, fanStatus.dutycycle does not need to be initialized NUM_OF_FANS_NAMES times.

based on the struct, fanStatus.dutycycle does not need to be initialized NUM_OF_FANS_NAMES times.

Do these variables need to be volatile?

Do these variables need to be volatile?

HD-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
HD-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Please see comment below regarding the changes in common from this code review.

Please see comment below regarding the changes in common from this code review.

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprin...

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprint_64 and the "branch from" should have been from staging. This code review has staging as the branch to review with master as the "branch review."