hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Mar 2022
1:29 pm

hnguyen  (deleted user)

Removed // if ( TRUE == getNoNewTreatmentStatus() ) //{ // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }

Removed
// if ( TRUE == getNoNewTreatmentStatus() )
//

Unknown macro: { // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }
1:28 pm

hnguyen  (deleted user)

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

1:27 pm

hnguyen  (deleted user)

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

1:18 pm

Sean Nash

Just delete this line of code.

Just delete this line of code.

1:17 pm

Sean Nash

Just delete this line of code.

Just delete this line of code.

1:17 pm

Sean Nash

Just delete this code.

Just delete this code.

1:14 pm

Sean Nash

It looks like staging branch has things the way it was too.

It looks like staging branch has things the way it was too.

1:04 pm

Sean Nash

Should be since last service (not last treatment).

Should be since last service (not last treatment).

10:43 am

dcox  (deleted user)

This was part of the merge from staging branch.

This was part of the merge from staging branch.

Thursday 17 Mar 2022
1:28 pm

Sean Nash

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

Friday 11 Mar 2022
3:10 pm

Michael Garthwaite

3:07 pm

Dara Navaei and Sean Nash

1:17 pm

Michael Garthwaite

HD-DEN-12121_SW Dev Sprint 65
HD-DEN-12121_SW Dev Sprint 65
11:11 am

Michael Garthwaite

0xA04E was originally MSG_ID_DG_HD_COMMUNICATION_STATUS_OVERRIDE. It was moved to 0xA008 due to an out of sync error in our lovely excel sheet. MSG_ID_DG_SET_FANS_RPM_ALARM_START_TIME_OFFSET should...

0xA04E was originally MSG_ID_DG_HD_COMMUNICATION_STATUS_OVERRIDE. It was moved to 0xA008 due to an out of sync error in our lovely excel sheet. MSG_ID_DG_SET_FANS_RPM_ALARM_START_TIME_OFFSET should now be 0xA04E.

Note: These values are what is currently reflected on staging.

10:36 am

Sean Nash

Where is 0xA04E?

Where is 0xA04E?

Thursday 10 Mar 2022
4:13 pm

Dara Navaei

HD-DEN-12121_SW Dev Sprint 65
HD-DEN-12121_SW Dev Sprint 65
10:19 am

dcox  (deleted user)

Added exception for Stopped sub states and before door should be closed.

Added exception for Stopped sub states and before door should be closed.

10:16 am

dcox  (deleted user)

Added

Added

10:16 am

dcox  (deleted user)

Added.

Added.

10:16 am

dcox  (deleted user)

Added.

Added.

10:15 am

dcox  (deleted user)

Good catch. Updated.

Good catch. Updated.

10:14 am

dcox  (deleted user)

Moved and used getSwitchStatus to ensure overrides work.

Moved and used getSwitchStatus to ensure overrides work.

Wednesday 09 Mar 2022
2:47 pm

dcox  (deleted user)

Sean said leave it as is. No harm to be done.

Sean said leave it as is. No harm to be done.

2:31 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:31 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:31 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:16 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:15 pm

Michael Garthwaite

Double #include. It is already written in SystemCommMessages.h

Double #include. It is already written in SystemCommMessages.h

11:50 am

Michael Garthwaite

Fixed. Changed Msg_id for this cmd to 0xA008 to prevent conflicts.

Fixed. Changed Msg_id for this cmd to 0xA008 to prevent conflicts.

11:27 am

dcox  (deleted user)

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.