hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 May 2022
1:44 pm

Sean Nash

DEN-12224: Fix to bug DEN-12833.

Options
    • -1
    • +7
    /firmware/App/Modes/TreatmentEnd.c
10:50 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
10:40 am

Dara Navaei

Merged DEN-12224

Options
    • -142
    • +189
    /firmware/App/Controllers/BloodLeak.c
    • -3
    • +1
    /firmware/App/Controllers/BloodLeak.h
    • -6
    • +8
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -7
    • +46
    /firmware/App/Services/SystemCommMessages.c
10:37 am

Dara Navaei

DEN-12224 updated the blood leak emebedded mode

Options
    • -10
    • +12
    /firmware/App/Controllers/BloodLeak.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -3
    • +36
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +3
    /firmware/App/Services/SystemCommMessages.h
Wednesday 11 May 2022
3:17 pm

dcox  (deleted user)

Done

Done

3:16 pm

dcox  (deleted user)

Done

Done

3:16 pm

dcox  (deleted user)

Done

Done

3:16 pm

dcox  (deleted user)

Done

Done

3:13 pm

Darren Cox <darren_m@cox.net>

DEN-12441 Code review comment updates 2.

Options
    • -8
    • +8
    /firmware/App/Modes/TreatmentStop.c
3:08 pm

Darren Cox <darren_m@cox.net>

DEN-12441 Code review comment updates.

Options
    • -19
    • +18
    /firmware/App/Modes/TreatmentStop.c
2:50 pm

dcox  (deleted user)

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

2:31 pm

dcox  (deleted user)

This was a place holder for NVRAM saving of Treatment Time. I removed it.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

2:30 pm

Darren Cox <darren_m@cox.net>

DEN-12441 Remove place holder for saving Treatment Time to NVRAM. No longer part of this task set.

Options
    • -17
    • +0
    /firmware/App/Modes/ModeTreatment.c
1:13 pm

Dara Navaei

1:13 pm

Dara Navaei

9:41 am

Sean Nash

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

9:40 am

Sean Nash

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

9:33 am

Sean Nash

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

9:29 am

Sean Nash

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

9:27 am

Sean Nash

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

9:10 am

Dara Navaei

DEN-12224 updated the blood leak embedded mode

Options
    • -141
    • +186
    /firmware/App/Controllers/BloodLeak.c
    • -3
    • +1
    /firmware/App/Controllers/BloodLeak.h
    • -6
    • +8
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +0
    /firmware/App/Modes/ModeService.c
    • -3
    • +0
    /firmware/App/Services/SystemComm.c
    • -4
    • +10
    /firmware/App/Services/SystemCommMessages.c
9:05 am

Sean Nash

What is the purpose of this new code? Should have a comment above to make clear. Need to address TODOs.

What is the purpose of this new code? Should have a comment above to make clear.
Need to address TODOs.

8:58 am

Dara Navaei

HD-DEN-12441_SW Dev Sprint 67 Darren
HD-DEN-12441_SW Dev Sprint 67 Darren
Tuesday 10 May 2022
1:36 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
12:14 pm

Darren Cox <darren_m@cox.net>

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
    • -0
    • +2
    /firmware/App/Modes/ModeTreatment.c
    • -4
    • +6
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +116
    /firmware/App/Services/SystemCommMessages.c
12:14 pm

Darren Cox <darren_m@cox.net>

DEN-12441 Resolve conflicts for merge with Develop.

Options
    • -15
    • +0
    /firmware/App/Modes/ModeTreatment.c
9:30 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
9:29 am

Sean Nash

Fixed merge conflicts.

Options
    • -96
    • +323
    /firmware/App/Controllers/BloodLeak.c
    • -1
    • +2
    /firmware/App/Controllers/BloodLeak.h
    • -4
    • +6
    /firmware/App/Controllers/SyringePump.c
    • -12
    • +20
    /firmware/App/Services/SystemComm.c
    • -1
    • +116
    /firmware/App/Services/SystemCommMessages.c
Monday 09 May 2022
2:01 pm

Sean Nash

DEN-12224: Fixes to Tx log event logging.

Options
    • -2
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +2
    /firmware/App/Modes/Dialysis.c
    • -0
    • +2
    /firmware/App/Modes/ModeTreatment.c
    • -1
    • +4
    /firmware/App/Modes/Rinseback.c
11:29 am

Sean Nash

DEN-12224: Added message support for UI to request going to service mode. Allow faults to be minimized.

Options
    • -2
    • +4
    /firmware/App/Services/AlarmMgmt.c
    • -21
    • +25
    /firmware/App/Services/SystemComm.c
    • -1
    • +66
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h