hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 May 2022
2:49 pm

dcox  (deleted user)

One letter enums could be more descriptive with their names.

One letter enums could be more descriptive with their names.

2:41 pm

dcox  (deleted user)

Why no SW Config in Release?

Why no SW Config in Release?

Wednesday 11 May 2022
3:17 pm

dcox  (deleted user)

Done

Done

3:16 pm

dcox  (deleted user)

Done

Done

3:16 pm

dcox  (deleted user)

Done

Done

3:16 pm

dcox  (deleted user)

Done

Done

2:50 pm

dcox  (deleted user)

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

2:31 pm

dcox  (deleted user)

This was a place holder for NVRAM saving of Treatment Time. I removed it.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

1:13 pm

Dara Navaei

1:13 pm

Dara Navaei

9:41 am

Sean Nash

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

9:40 am

Sean Nash

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

9:33 am

Sean Nash

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

9:29 am

Sean Nash

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

9:27 am

Sean Nash

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

9:05 am

Sean Nash

What is the purpose of this new code? Should have a comment above to make clear. Need to address TODOs.

What is the purpose of this new code? Should have a comment above to make clear.
Need to address TODOs.

8:58 am

Dara Navaei

HD-DEN-12441_SW Dev Sprint 67 Darren
HD-DEN-12441_SW Dev Sprint 67 Darren
Friday 15 Apr 2022
4:26 pm

Sean Nash

Dara removed this line of code after lab test w/o this change could not replicate the bug.

Dara removed this line of code after lab test w/o this change could not replicate the bug.

Thursday 14 Apr 2022
2:19 pm

Sean Nash

Why is this necessary. This is already called somewhere else.

Why is this necessary. This is already called somewhere else.

Thursday 07 Apr 2022
1:20 pm

Dara Navaei

1:20 pm

Behrouz NematiPour

Thursday 31 Mar 2022
2:23 pm

Dara Navaei

1:26 pm

Sean Nash , Dara Navaei and Michael Garthwaite

Wednesday 30 Mar 2022
2:40 pm

Michael Garthwaite

did we want to keep these loose tolerances from the demo?

did we want to keep these loose tolerances from the demo?

2:33 pm

Michael Garthwaite

We typically put #define like this in the source file. Is there a reason why this one is in the header file specifically?

We typically put #define like this in the source file. Is there a reason why this one is in the header file specifically?

2:29 pm

Michael Garthwaite

This variable is defined but not used.

This variable is defined but not used.

1:26 pm

Sean Nash

I wanted to see how new #define worked. I think it's better, so we can remove this now.

I wanted to see how new #define worked. I think it's better, so we can remove this now.

1:03 pm

Michael Garthwaite

Do we need to keep this define?

Do we need to keep this define?

12:45 pm

Michael Garthwaite

or this alarm?

or this alarm?

12:45 pm

Michael Garthwaite

Do we need to keep this alarm?

Do we need to keep this alarm?