Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 13 May 2022

10:55 am

Dara Navaei

More
0854767
changed 4 files
demo_branch, develop and 2 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

- -4
- +26
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -0
- +2
/firmware/App/Controllers/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.h
- -1
- +7
/firmware/App/Modes/TreatmentEnd.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentEnd.c
- -0
- +5
/firmware/App/Modes/TreatmentStop.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentStop.c

Thursday 12 May 2022

5:33 pm

Dara Navaei

More
43256ef
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-12224-dg_hd_dev-switches-monitor

5:33 pm

Dara Navaei

More
d96d180
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 updated the blood leak with an exit normal state command

- -4
- +26
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -0
- +2
/firmware/App/Controllers/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.h
- -0
- +5
/firmware/App/Modes/TreatmentStop.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentStop.c

2:49 pm

dcox (deleted user)

More
Re: HD-DEN-12224-16
commented on review

One letter enums could be more descriptive with their names.

One letter enums could be more descriptive with their names.

2:41 pm

dcox (deleted user)

More
Re: HD-DEN-12224-16
commented on review

Why no SW Config in Release?

Why no SW Config in Release?

1:44 pm

Sean Nash

More
be7a688
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-12224-dg_hd_dev-switches-monitor

1:44 pm

Sean Nash

More
69594ce
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224: Fix to bug DEN-12833.

- -1
- +7
/firmware/App/Modes/TreatmentEnd.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentEnd.c

10:50 am

Dara Navaei

More
935c047
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

10:40 am

Dara Navaei

More
4b83637
changed 5 files
demo_branch, develop and 2 more

Merged DEN-12224

- -142
- +189
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -3
- +1
/firmware/App/Controllers/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.h
- -6
- +8
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -7
- +46
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

10:37 am

Dara Navaei

More
6e86723
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 updated the blood leak emebedded mode

- -10
- +12
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -3
- +36
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -2
- +3
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

Wednesday 11 May 2022

3:17 pm

dcox (deleted user)

More
Re: HD-DEN-12441-3
replied to Sean Nash

Done

Done

3:16 pm

dcox (deleted user)

More
Re: HD-DEN-12441-3
replied to Sean Nash

Done

Done

3:16 pm

dcox (deleted user)

More
Re: HD-DEN-12441-3
replied to Sean Nash

Done

Done

3:16 pm

dcox (deleted user)

More
Re: HD-DEN-12441-3
replied to Sean Nash

Done

Done

3:13 pm

Darren Cox <darren_m@cox.net>

More
feeca8c
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 331 more HD-DEN-12441-3

DEN-12441 Code review comment updates 2.

- -8
- +8
/firmware/App/Modes/TreatmentStop.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentStop.c

3:08 pm

Darren Cox <darren_m@cox.net>

More
1ed47b0
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 331 more HD-DEN-12441-3

DEN-12441 Code review comment updates.

- -19
- +18
/firmware/App/Modes/TreatmentStop.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentStop.c

2:50 pm

dcox (deleted user)

More
Re: HD-DEN-12441-3
replied to Sean Nash

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

2:31 pm

dcox (deleted user)

More
Re: HD-DEN-12441-3
replied to Sean Nash

This was a place holder for NVRAM saving of Treatment Time. I removed it.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

2:30 pm

Darren Cox <darren_m@cox.net>

More
2a1db73
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 331 more HD-DEN-12441-3

DEN-12441 Remove place holder for saving Treatment Time to NVRAM. No longer part of this task set.

- -17
- +0
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c

1:13 pm

Dara Navaei

More
HD-DEN-12224-16
added dcox (deleted user)

1:13 pm

Dara Navaei

More
HD-DEN-12224-16
removed hnguyen (deleted user)

9:41 am

Sean Nash

More
Re: HD-DEN-12441-3
commented on review

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

9:40 am

Sean Nash

More
Re: HD-DEN-12441-3
commented on review

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

9:33 am

Sean Nash

More
Re: HD-DEN-12441-3
commented on review

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

9:29 am

Sean Nash

More
Re: HD-DEN-12441-3
commented on review

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

9:27 am

Sean Nash

More
Re: HD-DEN-12441-3
commented on review

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

9:10 am

Dara Navaei

More
0509843
changed 6 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 updated the blood leak embedded mode

- -141
- +186
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -3
- +1
/firmware/App/Controllers/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.h
- -6
- +8
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -3
- +0
/firmware/App/Modes/ModeService.c
- History
- Source
- Diff
/firmware/App/Modes/ModeService.c
- -3
- +0
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -4
- +10
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

9:05 am

Sean Nash

More
Re: HD-DEN-12441-3
commented on review

What is the purpose of this new code? Should have a comment above to make clear. Need to address TODOs.

What is the purpose of this new code? Should have a comment above to make clear.
Need to address TODOs.

8:58 am

Dara Navaei

More
HD-DEN-12441-3
started review

HD-DEN-12441_SW Dev Sprint 67 Darren

HD-DEN-12441_SW Dev Sprint 67 Darren

Tuesday 10 May 2022

1:36 pm

Dara Navaei

More
91cf64e
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 22:12 -0700