hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

One letter enums could be more descriptive with their names.

One letter enums could be more descriptive with their names.

Why no SW Config in Release?

Why no SW Config in Release?

Done

Done

Done

Done

Done

Done

Done

Done

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

What is the purpose of this new code? Should have a comment above to make clear. Need to address TODOs.

What is the purpose of this new code? Should have a comment above to make clear.
Need to address TODOs.

HD-DEN-12441_SW Dev Sprint 67 Darren
HD-DEN-12441_SW Dev Sprint 67 Darren
Dara removed this line of code after lab test w/o this change could not replicate the bug.

Dara removed this line of code after lab test w/o this change could not replicate the bug.

Why is this necessary. This is already called somewhere else.

Why is this necessary. This is already called somewhere else.