hdfirmware

Clone Tools

Stats

Commits this week: 3
Total Committers: 17
Last Commit: 29 Apr
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 22 May 2022
8:16 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -1
    • +0
    /firmware/App/Controllers/AirTrap.c
    • -3
    • +3
    /firmware/App/Controllers/Fans.c
    • -1
    • +1
    /firmware/App/Controllers/Fans.h
    • -2
    • +0
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.c
    • -9
    • +4
    /firmware/App/Services/SystemCommMessages.c
7:22 pm

Dara Navaei

Done.

Done.

7:20 pm

Dara Navaei

The other states ignore this flag and I have to set it here since this is a request.

The other states ignore this flag and I have to set it here since this is a request.

2:53 pm

Dara Navaei

For safety I do it here.

For safety I do it here.

2:53 pm

Dara Navaei

Done

Done

2:51 pm

Dara Navaei

Done

Done

2:48 pm

Dara Navaei

Done.

Done.

2:46 pm

Dara Navaei

Done.

Done.

2:46 pm

Dara Navaei

Done.

Done.

2:43 pm

Dara Navaei

Done.

Done.

2:40 pm

Dara Navaei

Removed the release check.

Removed the release check.

2:38 pm

Dara Navaei

Done

Done

2:03 pm

Dara Navaei

DEN-12224 updated the code

Options
    • -8
    • +11
    /firmware/App/Services/SystemCommMessages.c
Saturday 21 May 2022
11:56 pm

Dara Navaei

DEN-12224 updated the syscomm messages

Options
    • -18
    • +19
    /firmware/App/Services/SystemCommMessages.c
10:16 pm

Dara Navaei

DEN-12224 updated the files

Options
    • -398
    • +398
    /firmware/App/Controllers/Buttons.c
    • -1349
    • +1349
    /firmware/App/Services/SystemCommMessages.c
10:12 pm

Dara Navaei

DEN-12224 aligned the spaces in between the variables and datatypes

Options
    • -5
    • +5
    /firmware/App/HDCommon.h
Friday 20 May 2022
3:48 pm

Sean Nash

Remove blank line.

Remove blank line.

3:48 pm

Sean Nash

Remove blank line.

Remove blank line.

3:43 pm

Sean Nash

Remove blank line.

Remove blank line.

3:41 pm

Sean Nash

Why isn't this command allowed for release version?

Why isn't this command allowed for release version?

3:41 pm

Sean Nash

Is this zero temporary? If so, add TODO.

Is this zero temporary? If so, add TODO.

3:07 pm

Darren Cox <darren_m@cox.net>

DEN-12847 Add broadcast debug message for collecting stabel load cell drift data.

Options
    • -0
    • +7
    /firmware/App/Modes/Dialysis.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
3:02 pm

Sean Nash

I don't think we should exit normal mode in TreatmentStop sub-mode.

I don't think we should exit normal mode in TreatmentStop sub-mode.

3:01 pm

Sean Nash

Should we exit blood leak normal mode in here somewhere?

Should we exit blood leak normal mode in here somewhere?

2:45 pm

Sean Nash

Ask Behrouz if UI is still looking for this. Remove if not.

Ask Behrouz if UI is still looking for this. Remove if not.

2:32 pm

Steve Jarpe <sjarpe@diality.com>

undoing DG messaging for door switches

Options
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -41
    • +0
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
2:06 pm

Sean Nash

Remove extra blank line. And why is there any blank line here?

Remove extra blank line. And why is there any blank line here?

2:05 pm

Sean Nash

Seems like we're setting a start time offset here, not a time stamp.

Seems like we're setting a start time offset here, not a time stamp.

2:04 pm

Sean Nash

Should be rpmAlarmStartTime

Should be rpmAlarmStartTime

2:00 pm

Sean Nash

Did we want this offset to revert to zero here or should Dialin have to do a reset?

Did we want this offset to revert to zero here or should Dialin have to do a reset?