hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 May 2022
1:36 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -2
    • +2
    /firmware/App/Controllers/BloodLeak.c
    • -2
    • +1
    /firmware/App/Controllers/DialOutFlow.c
    • -2
    • +2
    /firmware/App/Controllers/Fans.c
    • -0
    • +3
    /firmware/App/Modes/TreatmentEnd.c
    • -3
    • +0
    /firmware/App/Modes/TreatmentStop.c
1:28 pm

Dara Navaei

Done.

Done.

1:20 pm

Dara Navaei

Done.

Done.

1:17 pm

Dara Navaei

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

1:17 pm

Dara Navaei

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

11:10 am

Dara Navaei

Thanks Michael, fixed it.

Thanks Michael, fixed it.

11:02 am

Michael Garthwaite

Not yet.

Not yet.

10:56 am

Michael Garthwaite

couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)

couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)

10:35 am

Dara Navaei

Done.

Done.

10:34 am

Dara Navaei

Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c

Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c

10:33 am

Dara Navaei

Michael Garthwaite do you have the latest tolerances after your testings?

Michael Garthwaite do you have the latest tolerances after your testings?

10:32 am

Dara Navaei

We should keep this state until we are sure it is no longer needed.

We should keep this state until we are sure it is no longer needed.

10:31 am

Dara Navaei

Done.

Done.

10:29 am

Dara Navaei

Done.

Done.

10:25 am

Dara Navaei

Done.

Done.

10:25 am

Dara Navaei

Done.

Done.

10:14 am

Michael Garthwaite

Wont these alarms be with an unknown alarm id for hd? it is created but not assigned.

Wont these alarms be with an unknown alarm id for hd? it is created but not assigned.

10:09 am

Dara Navaei

Done.

Done.

Sunday 22 May 2022
8:16 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -1
    • +0
    /firmware/App/Controllers/AirTrap.c
    • -3
    • +3
    /firmware/App/Controllers/Fans.c
    • -1
    • +1
    /firmware/App/Controllers/Fans.h
    • -2
    • +0
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.c
    • -9
    • +4
    /firmware/App/Services/SystemCommMessages.c
7:22 pm

Dara Navaei

Done.

Done.

7:20 pm

Dara Navaei

The other states ignore this flag and I have to set it here since this is a request.

The other states ignore this flag and I have to set it here since this is a request.

2:53 pm

Dara Navaei

For safety I do it here.

For safety I do it here.

2:53 pm

Dara Navaei

Done

Done

2:51 pm

Dara Navaei

Done

Done

2:48 pm

Dara Navaei

Done.

Done.

2:46 pm

Dara Navaei

Done.

Done.

2:46 pm

Dara Navaei

Done.

Done.

2:43 pm

Dara Navaei

Done.

Done.

2:40 pm

Dara Navaei

Removed the release check.

Removed the release check.

2:38 pm

Dara Navaei

Done

Done