hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into DEN-12609-sw_dev-sprint-69_mg

    • -48
    • +72
    /firmware/App/Controllers/PresOccl.c
    • -35
    • +97
    /firmware/App/Modes/ModePreTreat.c
    • -14
    • +19
    /firmware/App/Services/Reservoirs.c
DEN-12931: Addressed bug DEN-12830.

DEN-12931: Addressed bug DEN-12830.

DEN-12931 updated VectorCAST and the messages to be able to parse them

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +2
    /firmware/App/Controllers/DialOutFlow.c
  1. … 45 more files in changeset.
DEN-12224 addressed the code review comments

DEN-12224 updated the code and the VectorCAST per Pi Square's report

DEN-12224 updated VecotCAST with Pi Square's but report

    • -0
    • +3
    /firmware/App/Controllers/Temperatures.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

DEN-12224 addressed the code review comments

Done.

Done.

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatm...

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatment.

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

Spaces between parenthesis and condition.

Spaces between parenthesis and condition.

Space before final parenthesis.

Space before final parenthesis.

Remove blank line.

Remove blank line.

Should log volume level before and after.

Should log volume level before and after.

Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?

Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?

Remove blank line.

Remove blank line.

HD-DEN-12845_SW Dev Sprint S71 Steve
HD-DEN-12845_SW Dev Sprint S71 Steve
DEN-12845 updated the syringe pumpe event name

    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
DEN-12224 updated VectorCAST and addressed the code review comments

    • -1
    • +5
    /firmware/App/Controllers/DialOutFlow.c