hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Jun 2022
12:48 pm

Dara Navaei

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

Options
    • -190
    • +280
    /firmware/App/Controllers/BloodLeak.c
    • -0
    • +3
    /firmware/App/Controllers/DGInterface.h
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -3
    • +3
    /firmware/App/Modes/ConsumableSelfTest.c
    • -12
    • +13
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -0
    • +8
    /firmware/App/Services/SystemCommMessages.c
12:46 pm

Dara Navaei

DEN-12931 updated the blood leak embedded mode

Options
    • -78
    • +66
    /firmware/App/Controllers/BloodLeak.c
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
11:10 am

Sean Nash

11:09 am

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:08 am

Dara Navaei

DEN-12845 addressed the code review comments

Options
    • -8
    • +0
    /firmware/App/Services/SystemComm.c
    • -24
    • +0
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
9:49 am

Dara Navaei

Removed the message.

Removed the message.

9:27 am

Sean Nash

Should probably log ms - so need to multiply by task interval.

Should probably log ms - so need to multiply by task interval.

9:26 am

Sean Nash

This appears to be a timer counter (task intervals, not ms).

This appears to be a timer counter (task intervals, not ms).

9:24 am

Sean Nash

These are redundant with above. Keep above definitions as they have the 'F' suffix that we want. Remove these.

These are redundant with above. Keep above definitions as they have the 'F' suffix that we want. Remove these.

9:21 am

Sean Nash

Add blank line between functions.

Add blank line between functions.

9:20 am

Sean Nash

Not sure if this is an issue - but looks like this clear alarm condition check can happen even when occlusion level after install hasn't been set yet.

Not sure if this is an issue - but looks like this clear alarm condition check can happen even when occlusion level after install hasn't been set yet.

9:15 am

Sean Nash

Add space after ifs.

Add space after ifs.

Monday 13 Jun 2022
5:52 pm

Sean Nash

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), b...

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), but didn't want to apply the user provided limits - just want to monitor for max pressure situation.

3:34 pm

Michael Garthwaite

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment paramet...

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment parameters for the patient (Ex: -300 mmHg to -270 mmHg) and triggering a false positive alarm?

Note: I dont know actual patient bp values but these are currently acceptable treatment parameters for arterial pressure limits.

11:15 am

Dara Navaei

Merge branch 'staging' into DEN-12845-sw_dev_sprint_s71_steve

Options
    • -2
    • +2
    /firmware/App/Controllers/Buttons.c
    • -4
    • +4
    /firmware/App/Controllers/PresOccl.c
    • -2
    • +5
    /firmware/App/Controllers/Switches.c
    • -2
    • +2
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmt.c
    • -5
    • +11
    /firmware/App/Services/SystemComm.c
    • -7
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -4
    • +2
    /firmware/App/Services/SystemCommMessages.h
11:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:13 am

Dara Navaei

DEN-12845 addressed the code review comment

Options
    • -1
    • +0
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +2
    /firmware/App/Services/SystemCommMessages.c
11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:31 am

Dara Navaei

DEN-12845 addressed the code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +2
    /firmware/App/Controllers/Switches.c
    • -3
    • +3
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +0
    /firmware/App/Modes/ModeTreatment.c
    • -2
    • +4
    /firmware/App/Services/AlarmMgmt.c
    • -4
    • +1
    /firmware/App/Services/SystemCommMessages.c