hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Jul 2022
6:05 pm

Sean Nash

DEN-12931: Changed syringe pump calibration to expected DAC voltage. Added verification of calibration.

Options
    • -12
    • +12
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -3
    • +2
    /firmware/App/Services/SystemCommMessages.c
5:19 pm

Sean Nash

DEN-12931: Refactored syringe detection alarm mgmt.

Options
    • -16
    • +56
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -0
    • +3
    /firmware/App/Modes/ModeFault.c
    • -12
    • +3
    /firmware/App/Modes/ModePostTreat.c
    • -54
    • +4
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +6
    /firmware/App/Modes/ModeService.c
    • -0
    • +3
    /firmware/App/Modes/ModeStandby.c
4:25 pm

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:24 pm

Dara Navaei

DEN-12847 addressed code review comment

Options
    • -1
    • +0
    /firmware/App/Controllers/SyringePump.c
4:23 pm

Sean Nash

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

4:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Dara Navaei

DEN-12847 merged staging and addressed VectorCAST issues

Options
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -6
    • +24
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +14
    /firmware/App/Controllers/Switches.c
    • -2
    • +26
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +4
    /firmware/App/Modes/Dialysis.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
    • -4
    • +2
    /firmware/App/Services/SystemCommMessages.h
1:40 pm

Dara Navaei

DEN-12847 updated the code for VectorCAST

Options
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
12:59 pm

Sean Nash

DEN-12931: Refactored door and pump track alarm management.

Options
    • -26
    • +87
    /firmware/App/Controllers/Switches.c
    • -0
    • +1
    /firmware/App/Controllers/Switches.h
    • -7
    • +0
    /firmware/App/Controllers/Valves.c
    • -0
    • +2
    /firmware/App/Modes/BloodPrime.c
    • -0
    • +2
    /firmware/App/Modes/Dialysis.c
    • -20
    • +5
    /firmware/App/Modes/ModePostTreat.c
    • -24
    • +8
    /firmware/App/Modes/ModePreTreat.c
    • -2
    • +5
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -0
    • +2
    /firmware/App/Modes/Prime.c
    • -0
    • +2
    /firmware/App/Modes/Rinseback.c
    • -16
    • +10
    /firmware/App/Modes/SelfTests.c
    • -16
    • +10
    /firmware/App/Modes/TreatmentEnd.c
    • -0
    • +2
    /firmware/App/Modes/TreatmentRecirc.c
    • -0
    • +4
    /firmware/App/Modes/TreatmentStop.c
10:55 am

Dara Navaei

DEN-12847 addressed the code review comments and PiSquare's VectorCAST bugs

Options
    • -2
    • +2
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +0
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +0
    /firmware/App/Modes/Dialysis.c
    • -8
    • +8
    /firmware/App/Modes/Rinseback.c
10:48 am

Dara Navaei

Done.

Done.

10:47 am

Dara Navaei

Done.

Done.

10:46 am

Dara Navaei

Done.

Done.

10:46 am

Dara Navaei

Done.

Done.

10:32 am

Sean Nash

I don't think this does what we want anymore. Need to revisit VC issue.

I don't think this does what we want anymore. Need to revisit VC issue.

10:25 am

Sean Nash

Remove blank line.

Remove blank line.

Tuesday 12 Jul 2022
3:20 pm

Sean Nash

indent of cases looks too small.

indent of cases looks too small.

3:20 pm

Sean Nash

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?

3:17 pm

Sean Nash

Update input/outputs throughout.

Update input/outputs throughout.

3:13 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:03 pm

Sean Nash

DEN-12931: Added request for UI POST final result to ensure we get result before its needed in UI POST test.

Options
    • -0
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -3
    • +29
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Monday 11 Jul 2022
10:51 pm

Dara Navaei

DEN-12847 addressed the VectorCAST issues reported by PiSquare

Options
    • -1
    • +1
    /firmware/App/Controllers/Fans.c
    • -0
    • +3
    /firmware/App/Controllers/Switches.c
    • -9
    • +11
    /firmware/App/Controllers/SyringePump.c
    • -7
    • +11
    /firmware/App/Controllers/Valves.c
    • -3
    • +0
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
Thursday 07 Jul 2022
5:26 pm

Sean Nash

DEN-12931: Fixed bug in setup for dialyzer prime step.

Options
    • -1
    • +1
    /firmware/App/Modes/Prime.c
1:28 pm

Michael Garthwaite

Do we want to keep this debug & sprintf?

Do we want to keep this debug & sprintf?

7:04 am

Dara Navaei

HD-DEN-12931_DG HD Dev HD DG Dvt Update
HD-DEN-12931_DG HD Dev HD DG Dvt Update
Friday 01 Jul 2022
10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.