hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 19 Jul 2022
2:34 pm

Sean Nash

DEN-13460: Updated arterial pressure limits range. Added actuators homing to standby start state.

Options
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -3
    • +6
    /firmware/App/Controllers/Valves.c
    • -1
    • +45
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    /firmware/App/Modes/SelfTests.c
Monday 18 Jul 2022
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.

Friday 15 Jul 2022
8:32 pm

Dara Navaei

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-12931-dg_hd_dev-hd_dg_dvt-update

Options
8:32 pm

Dara Navaei

DEN-12931 added isnan math function to prevent NaN values to be used in HD

Options
    • -0
    • +8
    /firmware/App/Controllers/DGInterface.c
2:21 pm

Michael Garthwaite

DEN-13427: Added events for wet self test results.

Options
    • -0
    • +4
    /firmware/App/Modes/SelfTests.c
11:24 am

Sean Nash

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-12931-dg_hd_dev-hd_dg_dvt-update

Options
11:24 am

Sean Nash

DEN-12931: Updated blood flow estimation parameters for new tubing.

Options
    • -3
    • +3
    /firmware/App/Controllers/BloodFlow.c
8:47 am

Dara Navaei

Merged staging and resolved the conflicts

Options
    • -1
    • +4
    /firmware/App/Controllers/DGInterface.h
    • -2
    • +3
    /firmware/App/Controllers/Switches.c
    • -11
    • +7
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +62
    /firmware/App/Modes/Dialysis.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -4
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -9
    • +9
    /firmware/App/Modes/Rinseback.c
    • -4
    • +1
    /firmware/App/Services/SystemCommMessages.h
Wednesday 13 Jul 2022
8:50 pm

Dara Navaei

8:49 pm

Sean Nash and Michael Garthwaite

8:27 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
8:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Controllers/Switches.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/Modes/Dialysis.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
8:21 pm

Dara Navaei

DEN-12847 removed AC POST

Options
    • -8
    • +0
    /firmware/App/Modes/ModeInitPOST.c
6:27 pm

Sean Nash

DEN-12931: Removed POST test for checking if booting from battery.

Options
    • -8
    • +0
    /firmware/App/Modes/ModeInitPOST.c
6:05 pm

Sean Nash

DEN-12931: Changed syringe pump calibration to expected DAC voltage. Added verification of calibration.

Options
    • -12
    • +12
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -3
    • +2
    /firmware/App/Services/SystemCommMessages.c
5:19 pm

Sean Nash

DEN-12931: Refactored syringe detection alarm mgmt.

Options
    • -16
    • +56
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -0
    • +3
    /firmware/App/Modes/ModeFault.c
    • -12
    • +3
    /firmware/App/Modes/ModePostTreat.c
    • -54
    • +4
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +6
    /firmware/App/Modes/ModeService.c
    • -0
    • +3
    /firmware/App/Modes/ModeStandby.c
4:25 pm

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:24 pm

Dara Navaei

DEN-12847 addressed code review comment

Options
    • -1
    • +0
    /firmware/App/Controllers/SyringePump.c
4:23 pm

Sean Nash

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

4:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Dara Navaei

DEN-12847 merged staging and addressed VectorCAST issues

Options
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -6
    • +24
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +14
    /firmware/App/Controllers/Switches.c
    • -2
    • +26
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +4
    /firmware/App/Modes/Dialysis.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
    • -4
    • +2
    /firmware/App/Services/SystemCommMessages.h
1:40 pm

Dara Navaei

DEN-12847 updated the code for VectorCAST

Options
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
12:59 pm

Sean Nash

DEN-12931: Refactored door and pump track alarm management.

Options
    • -26
    • +87
    /firmware/App/Controllers/Switches.c
    • -0
    • +1
    /firmware/App/Controllers/Switches.h
    • -7
    • +0
    /firmware/App/Controllers/Valves.c
    • -0
    • +2
    /firmware/App/Modes/BloodPrime.c
    • -0
    • +2
    /firmware/App/Modes/Dialysis.c
    • -20
    • +5
    /firmware/App/Modes/ModePostTreat.c
    • -24
    • +8
    /firmware/App/Modes/ModePreTreat.c
    • -2
    • +5
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -0
    • +2
    /firmware/App/Modes/Prime.c
    • -0
    • +2
    /firmware/App/Modes/Rinseback.c
    • -16
    • +10
    /firmware/App/Modes/SelfTests.c
    • -16
    • +10
    /firmware/App/Modes/TreatmentEnd.c
    • -0
    • +2
    /firmware/App/Modes/TreatmentRecirc.c
    • -0
    • +4
    /firmware/App/Modes/TreatmentStop.c
10:55 am

Dara Navaei

DEN-12847 addressed the code review comments and PiSquare's VectorCAST bugs

Options
    • -2
    • +2
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +0
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +0
    /firmware/App/Modes/Dialysis.c
    • -8
    • +8
    /firmware/App/Modes/Rinseback.c