hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 Jul 2022
10:13 am

Darren Cox

Removed.

Removed.

10:13 am

Darren Cox

Fixed. Good catch. started with boolean, but changed to enum.

Fixed. Good catch. started with boolean, but changed to enum.

10:12 am

Darren Cox

Modified names

Modified names

Friday 22 Jul 2022
1:29 pm

Sean Nash

Can we remove this now?

Can we remove this now?

1:27 pm

Sean Nash

I though cycle was an enum (start/final), not a boolean. Should we be looking for final (not TRUE)?

I though cycle was an enum (start/final), not a boolean. Should we be looking for final (not TRUE)?

1:20 pm

Sean Nash

Better name is reservoir use cycle steady sample points (during treatment, but we're in Dialysis.c here so treatment can be inferred).

Better name is reservoir use cycle steady sample points (during treatment, but we're in Dialysis.c here so treatment can be inferred).

12:48 pm

Dara Navaei

HD-DEN-13167_SW Dev Sprint 74 Darren
HD-DEN-13167_SW Dev Sprint 74 Darren
8:28 am

Sean Nash

Why removed?

Why removed?

8:27 am

Sean Nash

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

Thursday 21 Jul 2022
9:03 pm

Sean Nash

F has been added.

F has been added.

9:01 pm

Sean Nash

No. Code removed.

No. Code removed.

8:58 pm

Sean Nash

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

8:52 pm

Sean Nash

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

8:50 pm

Sean Nash

Remove blank line.

Remove blank line.

8:49 pm

Sean Nash

Can we remove this now?

Can we remove this now?

5:08 pm

Sean Nash

Why?

Why?

5:08 pm

Sean Nash

Why?

Why?

4:28 pm

Dara Navaei

HD-DEN-13141_Miscellaneous HD Issues BB
HD-DEN-13141_Miscellaneous HD Issues BB
Monday 18 Jul 2022
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.

Wednesday 13 Jul 2022
8:50 pm

Dara Navaei

8:49 pm

Sean Nash and Michael Garthwaite

4:25 pm

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:23 pm

Sean Nash

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

4:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.