Activity hdfirmware/

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of th...

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of the 3 registers (or the 3rd of the 3 if they are always next to each other in enum in same order) has been read (call publish function from the cases where we read one of the 3 registers). If you publish after reading any of the 3, you could sometimes get broadcast 250ms apart. If you publish after reading the last of the 3 in a group (i.e. the status_1, remaining_capacity_1, charger_status_1), the spacing of the broadcast will depend on how many enums are between them.

3:48 pm

Michael Garthwaite

More
1fb211e
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 314 more HD-DEN-13903-1

DEN-13903: DIAL-204: fixed DOP set PWM to not convert from PWM to ml/min twice.

- -1
- +1
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c

3:44 pm

Michael Garthwaite

More
f9bd8b1
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 309 more HD-DEN-13903-2

DEN-13903: Added fast flow rate for blood circ sub state within priming.

- -2
- +11
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

3:39 pm

Dara Navaei

More
c459716
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 311 more HD-DEN-13834-1

DEN-13834 updated the code with the latest FPGA persistent alarms

- -1
- +3
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -6
- +9
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -23
- +12
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c
- -91
- +36
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -17
- +9
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -56
- +40
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -2
- +1
/firmware/App/Services/FPGA.h
- History
- Source
- Diff
/firmware/App/Services/FPGA.h

12:34 pm

Steve Jarpe <sjarpe@diality.com>

More
71a7f09
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 312 more HD-DEN-14001-1

DEN-14001. Restored original method of retrieving battery pack and battery charger data. Only one value is read each time through the state. Some values are read more often.

- -94
- +119
/firmware/App/Drivers/Battery.c
- History
- Source
- Diff
/firmware/App/Drivers/Battery.c

10:58 am

wbracken (deleted user)

More
Re: HD-DEN-14001-1
commented on review

BatteryStatusData is an input.

10:48 am

wbracken (deleted user)

More
Re: HD-DEN-13834-1
commented on review

fpgaPersistentAlarmGroup is an input.

10:44 am

wbracken (deleted user)

More
Re: HD-DEN-13834-1
commented on review

Are all available ALARM_IDs being removed?

10:26 am

Steve Jarpe

More
Re: HD-DEN-14001-1
replied to Sean Nash

OK, I see what you wanted. I have a couple of questions: Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct? If so, could that ...

OK, I see what you wanted. I have a couple of questions:
Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct?
If so, could that be done by calling the publishBatteryStatusData function when the 3rd value (charger status) is read?

4:38 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

Restore alarm when done.

4:27 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

I think we should just be calling one function to do a single read at a time. If you try to read multiple times back-to-back, the bus reports busy and the read fails. I would keep call to getBatter...

I think we should just be calling one function to do a single read at a time. If you try to read multiple times back-to-back, the bus reports busy and the read fails. I would keep call to getBatteryManagementData() function with the large switch statement as it was with everything there and remove getBatteryStatusData() function altogether.

4:24 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

Keep multiple reads of remaining capacity and status in the switch as before.

4:23 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

Keep read for battery charger status here before end of list.

4:22 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

Dong fixed this.

4:22 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

Need to save data to dataPtr so calling function gets the data.

4:21 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these ...

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these enums was the way to achieve that - with the multiple status1..5 and remaining capacity1..5 enums spaced out to get them read more frequently.
And I think the individual cases for the higher frequency registers could just call the high frequency broadcast function whenever a new value is read for those registers. And so the slower broadcast could stay at end of list in that switch statement.

3:58 pm