hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Oct 2022
8:35 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14001-hd-battery-driver-update. Addressed remaining code review comments. Changed I2C timeout from 1 ms to 2 ms. Updated headers in some functions. Removed extra blank lines.

Options
    • -12
    • +13
    /firmware/App/Drivers/Battery.c
6:48 pm

wbracken  (deleted user)

BatteryStatusData is also an input

BatteryStatusData is also an input

Tuesday 04 Oct 2022
6:02 pm

Sean Nash

Add 2 blank lines before test support banner.

Add 2 blank lines before test support banner.

6:01 pm

Sean Nash

Remove extra blank lines. Should only be 1 here.

Remove extra blank lines. Should only be 1 here.

6:01 pm

Sean Nash

Cases should be pulled back one indent (4 spaces) to align with others.

Cases should be pulled back one indent (4 spaces) to align with others.

5:59 pm

Sean Nash

Add blank line after declaration.

Add blank line after declaration.

5:59 pm

Sean Nash

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time. Recommend changing this to 2 ms timeout.

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time.
Recommend changing this to 2 ms timeout.

5:53 pm

Sean Nash

Why not checking payload length?

Why not checking payload length?

5:52 pm

Sean Nash

Keep blank line.

Keep blank line.

5:48 pm

Sean Nash

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers...

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers as "reserved" for future purpose.
Dara, I do think we could rename these register fields to something like Reserved1, Reserved2, ...

5:43 pm

Sean Nash

Monitor execs should be before operation modes exec.

Monitor execs should be before operation modes exec.

5:37 pm

Sean Nash

Why was blank line removed?

Why was blank line removed?

5:29 pm

Sean Nash

Align "=".

Align "=".

5:27 pm

Sean Nash

Add another blank line here.

Add another blank line here.

5:22 pm

Sean Nash

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

4:34 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14001: Update battery driver.

Options
    • -1
    • +1
    /firmware/App/Drivers/Battery.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
12:54 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14001: Updated Battery.c and Battery.h

Options
    • -178
    • +203
    /firmware/App/Drivers/Battery.c
12:38 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14001: Update Battery.c

Options
    • -4
    • +4
    /firmware/App/Drivers/Battery.c
11:53 am

wbracken  (deleted user)

Does didTimeout support a 1ms timeout?

Does didTimeout support a 1ms timeout?

11:07 am

wbracken  (deleted user)

What is the significance of (OBSOLETE)? Applies to several blocks.

What is the significance of (OBSOLETE)? Applies to several blocks.

10:57 am

Michael Garthwaite

Merge branch 'DEN-13903-sprint-80_mg_air_trap_optimization' into develop

Options
    • -2
    • +11
    /firmware/App/Modes/Prime.c
8:33 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
8:33 am

Michael Garthwaite

Merge branch 'DEN-13903-s80-mg-DIAL-204' into develop

Options
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
Monday 03 Oct 2022
4:14 pm

Sean Nash

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of th...

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of the 3 registers (or the 3rd of the 3 if they are always next to each other in enum in same order) has been read (call publish function from the cases where we read one of the 3 registers). If you publish after reading any of the 3, you could sometimes get broadcast 250ms apart. If you publish after reading the last of the 3 in a group (i.e. the status_1, remaining_capacity_1, charger_status_1), the spacing of the broadcast will depend on how many enums are between them.

3:48 pm

Michael Garthwaite

DEN-13903: DIAL-204: fixed DOP set PWM to not convert from PWM to ml/min twice.

Options
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
3:44 pm

Michael Garthwaite

DEN-13903: Added fast flow rate for blood circ sub state within priming.

Options
    • -2
    • +11
    /firmware/App/Modes/Prime.c
3:39 pm

Dara Navaei

DEN-13834 updated the code with the latest FPGA persistent alarms

Options
    • -1
    • +3
    /firmware/App/Controllers/BloodLeak.c
    • -6
    • +9
    /firmware/App/Controllers/DGInterface.c
    • -23
    • +12
    /firmware/App/Controllers/Fans.c
    • -91
    • +36
    /firmware/App/Controllers/PresOccl.c
    • -17
    • +9
    /firmware/App/Controllers/SyringePump.c
    • -56
    • +40
    /firmware/App/Services/FPGA.c
    • -2
    • +1
    /firmware/App/Services/FPGA.h
12:34 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14001. Restored original method of retrieving battery pack and battery charger data. Only one value is read each time through the state. Some values are read more often.

Options
    • -94
    • +119
    /firmware/App/Drivers/Battery.c
10:58 am

wbracken  (deleted user)

BatteryStatusData is an input.

BatteryStatusData is an input.

10:48 am

wbracken  (deleted user)

fpgaPersistentAlarmGroup is an input.

fpgaPersistentAlarmGroup is an input.