hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Updated the valves drivers by widening the position out of range tolerance

    • -13
    • +14
    /firmware/App/Controllers/Valves.c
Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

Should add a break from loop here.

Should add a break from loop here.

Convention is to ack when receiving one-shot (not broadcast) messages like this.

Convention is to ack when receiving one-shot (not broadcast) messages like this.

Should break out of loop here I think.

Should break out of loop here I think.

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more norm...

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more normal functions down here too that should be moved.

Change to "0 == disinfectCancelReqID"

Change to "0 == disinfectCancelReqID"

Why absolute value?

Why absolute value?

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?

Should add a comment for this (and maybe a #define). Looks like this value will prevail if measured RPM is zero so would expect infinite persist I guess - though shouldn't be calling this function ...

Should add a comment for this (and maybe a #define). Looks like this value will prevail if measured RPM is zero so would expect infinite persist I guess - though shouldn't be calling this function when pump is stopped I would think. Should probably be 8 Fs (not 7).

Why don't we want to distinguish forward and reverse speeds with sign?

Why don't we want to distinguish forward and reverse speeds with sign?

Is this reject from HD or user or both? Comment suggests from HD only.

Is this reject from HD or user or both? Comment suggests from HD only.

GENERIC_CONFIGURE == disinfectCancelRegID

GENERIC_CONFIGURE == disinfectCancelRegID

Does this need to handle lowercase hex characters and invalid characters?

Does this need to handle lowercase hex characters and invalid characters?

Merge branch 'DEN-14001-hd-battery-driver-update' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14001-hd-battery-driver-update

DEN-14001: Update battery driver

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Merge branch 'DEN-14000-sw_dev_sprint_80_darren' into develop

    • -10
    • +24
    /firmware/App/Modes/ModeStandby.c
DEN-14000 Updated for HDDefs Confirm defines and updated parameters for confirm messages.

    • -10
    • +24
    /firmware/App/Modes/ModeStandby.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' into develop

DEN-13834 updated the semaphore

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.