hdfirmware

Clone Tools

Stats

Commits this week: 13
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 10 Oct 2022
12:51 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
12:50 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-14000-sw_dev_sprint_80_darren' into develop

Options
    • -2
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -14
    • +17
    /firmware/App/Services/SystemCommMessages.c
12:43 pm

dcox  (deleted user)

Updated to define, added comment.

Updated to define, added comment.

12:42 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Remove magic number, add explanation comment.

Options
    • -2
    • +1
    /firmware/App/Controllers/DialInFlow.c
12:41 pm

dcox  (deleted user)

Updated.

Updated.

12:40 pm

dcox  (deleted user)

This enum is HD to UI only. Updated comments.

This enum is HD to UI only. Updated comments.

11:00 am

dcox  (deleted user)

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:59 am

dcox  (deleted user)

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:59 am

dcox  (deleted user)

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:37 am

dcox  (deleted user)

Updated.

Updated.

10:36 am

dcox  (deleted user)

Updated.

Updated.

10:36 am

dcox  (deleted user)

Done.

Done.

10:36 am

dcox  (deleted user)

Updated.

Updated.

10:35 am

dcox  (deleted user)

Comment removed, Ack kept.

Comment removed, Ack kept.

10:35 am

dcox  (deleted user)

done.

done.

10:34 am

dcox  (deleted user)

updated to use pointer.

updated to use pointer.

Friday 07 Oct 2022
3:40 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Code Review comment updates.

Options
    • -2
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -14
    • +17
    /firmware/App/Services/SystemCommMessages.c
1:17 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
1:16 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-14000-sw_dev_sprint_80_darren' into develop

Options
    • -0
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +5
    /firmware/App/Services/SystemCommMessages.c
1:16 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Add response for Confirm Cancel. Fix parameters U32 value for Confirm messages.

Options
    • -0
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +5
    /firmware/App/Services/SystemCommMessages.c
11:08 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
11:05 am

Dara Navaei

Updated the valves drivers by widening the position out of range tolerance

Options
    • -13
    • +14
    /firmware/App/Controllers/Valves.c
10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:48 am

Sean Nash

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

10:35 am

Sean Nash

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

10:29 am

Sean Nash

Should add a break from loop here.

Should add a break from loop here.

10:25 am

Sean Nash

Convention is to ack when receiving one-shot (not broadcast) messages like this.

Convention is to ack when receiving one-shot (not broadcast) messages like this.

10:21 am

Sean Nash

Should break out of loop here I think.

Should break out of loop here I think.

10:19 am

Sean Nash

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).