hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Oct 2022
3:29 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Code review comments updates.

Options
    • -4
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -72
    • +67
    /firmware/App/Services/SystemCommMessages.c
3:05 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:04 pm

Michael Garthwaite

DEN-13903: code review comments

Options
    • -1
    • +1
    /firmware/App/Modes/Prime.c
3:02 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:01 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:01 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:00 pm

Michael Garthwaite

DEN-13903: code review changes.

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -1
    • +0
    /firmware/App/Modes/Prime.c
2:59 pm

Michael Garthwaite

Please see comment above.

Please see comment above.

2:59 pm

Michael Garthwaite

During Saline circ blood circuit state, we are also running the BP at the same rate as purge air as we monitor the level. Do we want the first pass of that state to be ramped up? Also, DPi?

During Saline circ blood circuit state, we are also running the BP at the same rate as purge air as we monitor the level. Do we want the first pass of that state to be ramped up? Also, DPi?

2:56 pm

Michael Garthwaite

This is blood flow?

This is blood flow?

2:55 pm

Michael Garthwaite

This is an older style of persistence? line 214 shows that airTrapIllegalLevelSensorsCtr gets decremented if it is greater than 0.

This is an older style of persistence? line 214 shows that airTrapIllegalLevelSensorsCtr gets decremented if it is greater than 0.

2:05 pm

Dara Navaei

DEN-13834 addressed the code review comments

Options
    • -0
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Controllers/Temperatures.c
    • -0
    • +3
    /firmware/App/Modes/ModeFault.c
    • -0
    • +1
    /firmware/App/Modes/Prime.c
    • -3
    • +3
    /firmware/App/Tasks/TaskGeneral.c
1:38 pm

Dara Navaei

Done. The ranks will be redefined.

Done. The ranks will be redefined.

1:36 pm

Dara Navaei

Done.

Done.

1:35 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14001: Update battery driver

Options
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -9
    • +6
    /firmware/App/Drivers/Battery.c
1:31 pm

Dara Navaei

Done.

Done.

1:31 pm

Michael Garthwaite

DEN-13903: code review fixes for merging.

Options
    • -0
    • +1
    /firmware/App/Modes/Prime.c
1:30 pm

Dara Navaei

Done.

Done.

1:30 pm

Dara Navaei

Done.

Done.

1:29 pm

Dara Navaei

Done.

Done.

1:25 pm

Dara Navaei

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

1:21 pm

Dara Navaei

Done.

Done.

1:20 pm

Dara Navaei

I am waiting for HDD to be updated to reserved so I can rename them.

I am waiting for HDD to be updated to reserved so I can rename them.

1:19 pm

Dara Navaei

Done.

Done.

1:18 pm

Dara Navaei

Done.

Done.

1:16 pm

Dara Navaei

Done.

Done.

1:16 pm

Dara Navaei

Done.

Done.

1:12 pm

Dara Navaei

Done.

Done.

12:43 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Code review updates.

Options
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -4
    • +3
    /firmware/App/Modes/OperationModes.h
    • -1
    • +2
    /firmware/App/Services/SystemCommMessages.h
10:10 am

Sean Nash

Can we assign request_type here at declaration instead of below?

Can we assign request_type here at declaration instead of below?