Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 13 Oct 2022

11:06 pm

Sean Nash

More
630686d
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 312 more HD-DEN-14001-1

DEN-14001: Addressed code review comments.

- -0
- +1
/firmware/App/Drivers/Battery.c
- History
- Source
- Diff
/firmware/App/Drivers/Battery.c
- -1
- +0
/firmware/App/Tasks/TaskBG.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskBG.c

11:04 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:04 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 pm

Sean Nash

More
Re: HD-DEN-14001-1
commented on review

Remove this blank line.

Remove this blank line.

10:55 pm

Sean Nash

More
Re: HD-DEN-14001-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:29 pm

Sean Nash

More
Re: HD-DEN-13801-1
replied to dcox (deleted user)

Last value is U32 (this is a structure, not an array). "F" suffix is not required for typed assignments. Required for potentially untyped #defines /expressions / ...

Last value is U32 (this is a structure, not an array). "F" suffix is not required for typed assignments. Required for potentially untyped #defines /expressions / ...

9:01 am

Sean Nash

Why can't we rename them ourselves? Let's just do it now.

Why can't we rename them ourselves? Let's just do it now.

8:55 am

Sean Nash

I don't understand. It's used by nv data but it's not currently used? This enum is supposed to an enum of events that can be sent to UI for logging. Why would we want to log a non-event?

I don't understand. It's used by nv data but it's not currently used? This enum is supposed to an enum of events that can be sent to UI for logging. Why would we want to log a non-event?

8:51 am

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

This looked better before. Why change?

This looked better before. Why change?

Wednesday 12 Oct 2022

5:29 pm

Dara Navaei

More
8a44631
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 313 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

4:38 pm

Dara Navaei

More
8e306a1
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 313 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

4:38 pm

Dara Navaei

More
a4e0443
changed 10 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 313 more HD-DEN-13834-1 HD-DEN-14000-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -2
- +2
/firmware/App/Controllers/BloodFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.h
- -2
- +2
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -2
- +2
/firmware/App/Controllers/DialInFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.h
- -2
- +2
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -2
- +2
/firmware/App/Controllers/DialOutFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.h
- -2
- +2
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -2
- +2
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -2
- +2
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

4:33 pm

Michael Garthwaite

More
HD-DEN-13903-1
Closed

4:30 pm

wbracken (deleted user) and Sean Nash

More
HD-DEN-13903-1
finished reviewing

4:20 pm

Dara Navaei

More
344e605
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

4:19 pm

Michael Garthwaite

More
ae1bfe6
changed 4 files
develop

Merge branch 'DEN-13903-s80-mg-DIAL-204' into develop

- -3
- +4
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -7
- +7
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -6
- +6
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -1
- +0
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

4:16 pm

Michael Garthwaite

More
ca777b9
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 313 more

Merge branch 'DEN-13903-s80-mg-DIAL-204' into staging

4:09 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:08 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:08 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:08 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 18:16 -0700