hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3

    • -2
    • +3
    /firmware/App/Controllers/DialOutFlow.h
    • -2
    • +14
    /firmware/App/Services/SystemComm.c
Done.

Done.

This was changed to be consistent with the rest of the FAPI if statements.

This was changed to be consistent with the rest of the FAPI if statements.

Done.

Done.

DEN-13834 addressed the code review comments

    • -7
    • +9
    /firmware/App/Drivers/SafetyShutdown.c
    • -18
    • +17
    /firmware/App/Services/WatchdogMgmt.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Still below operation modes exec.

Still below operation modes exec.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Why are we setting BP speed here? Wouldn't BP already be setup prior to this state? What does fluid at lower level have to do with BP speed?

Why are we setting BP speed here? Wouldn't BP already be setup prior to this state? What does fluid at lower level have to do with BP speed?

Wouldn't we set primeFirstPurgePass to FALSE here (we've just completed first pass and we're leaving)? And so shouldn't we just set BP to the faster rate now?

Wouldn't we set primeFirstPurgePass to FALSE here (we've just completed first pass and we're leaving)? And so shouldn't we just set BP to the faster rate now?

Addressed code review comments.

    • -0
    • +1
    /firmware/App/Controllers/DialInFlow.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.