hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 Oct 2022
7:08 pm

Sean Nash

DEN-14001: Addressed code review comments.

Options
    • -58
    • +58
    /firmware/App/Drivers/Battery.c
6:57 pm

Sean Nash

Fixed.

Fixed.

6:55 pm

Sean Nash

Added.

Added.

6:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

6:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

6:11 pm

Sean Nash

Fixed.

Fixed.

5:42 pm

Sean Nash

Agree. Change "_SECOND" to "_IN_TREATMENT"

Agree. Change "_SECOND" to "_IN_TREATMENT"

5:40 pm

Sean Nash

This should be the first if and the one above should just be an else (no if).

This should be the first if and the one above should just be an else (no if).

5:38 pm

Sean Nash

Remove extra space after static.

Remove extra space after static.

3:14 pm

wbracken  (deleted user)

If not used should be removed.

If not used should be removed.

3:11 pm

Dara Navaei

DEN-13834 addressed the code review comments and initialized some variables per CppCheck

Options
    • -1
    • +2
    /firmware/App/Controllers/BloodLeak.c
    • -10
    • +10
    /firmware/App/Services/SystemCommMessages.c
3:08 pm

Dara Navaei

Added them to the doxygen comments.

Added them to the doxygen comments.

3:07 pm

wbracken  (deleted user)

Update function header. dialysateInPumpRotorCounter.data, dipStopAtHomePosition also output.

Update function header. dialysateInPumpRotorCounter.data, dipStopAtHomePosition also output.

3:01 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:51 pm

wbracken  (deleted user)

Are bloodLeakEmbModeHasZeroBeenRqustd and bloodLeakSelfTestStatus both global?

Are bloodLeakEmbModeHasZeroBeenRqustd and bloodLeakSelfTestStatus both global?

2:42 pm

Dara Navaei

HD-DEN-14150_HD Dialysate Flow Estimation
HD-DEN-14150_HD Dialysate Flow Estimation
2:26 pm

Michael Garthwaite

DEN-13801: Dry Self changes based on feedback.

Options
    • -5
    • +5
    /firmware/App/Modes/SelfTests.c
2:03 pm

Dara Navaei

Done.

Done.

1:57 pm

Dara Navaei

DEN-13834 addressed the code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/BloodLeak.c
    • -11
    • +8
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/HDCommon.h
    • -1
    • +1
    /firmware/App/Modes/BloodPrime.c
    • -1
    • +1
    /firmware/App/Modes/Dialysis.c
    • -1
    • +1
    /firmware/App/Modes/ModeFault.c
    • -5
    • +4
    /firmware/App/Modes/Prime.c
    • -228
    • +27
    /firmware/App/Services/FPGA.c
    • -16
    • +1
    /firmware/App/Services/FPGA.h
    • -14
    • +16
    /firmware/App/Services/SystemCommMessages.c
    • -4
    • +4
    /firmware/App/Services/WatchdogMgmt.c
    • -4
    • +3
    /firmware/App/Tasks/TaskGeneral.c
1:53 pm

Dara Navaei

Removed the "no event" event.

Removed the "no event" event.

1:48 pm

Dara Navaei

Removed it.

Removed it.

1:47 pm

Dara Navaei

Done.

Done.

1:18 pm

Dara Navaei

Done.

Done.

1:17 pm

Dara Navaei

Done.

Done.

1:14 pm

Dara Navaei

It is uncommented.

It is uncommented.

1:12 pm

Dara Navaei

Done.

Done.

1:11 pm

Dara Navaei

This is an old code and it has been removed.

This is an old code and it has been removed.

1:11 pm

Dara Navaei

This is an old code and it has been removed.

This is an old code and it has been removed.

1:10 pm

Dara Navaei

This is an old code and it has been removed.

This is an old code and it has been removed.

11:58 am

Michael Garthwaite

DEN-13801: reworked dry self test tolerances to be more in line with data.

Options
    • -9
    • +14
    /firmware/App/Modes/SelfTests.c