hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 21 Oct 2022
3:38 pm

Dara Navaei

DEN-14166 addressed a code review comment

Options
    • -0
    • +1
    /firmware/App/Controllers/BloodLeak.c
3:38 pm

Dara Navaei

Done.

Done.

3:37 pm

Dara Navaei

Done.

Done.

2:57 pm

Sean Nash

Fine for now. This one should probably just reset to zero on else instead of decrement. RESOLVED in CODE WALKTHROUGH.

Fine for now. This one should probably just reset to zero on else instead of decrement.
RESOLVED in CODE WALKTHROUGH.

2:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:53 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:52 pm

Michael Garthwaite

Fixed. Using the old style for now. Will rework both alarms to use new persistence when we revisit the dialyzer timeout alarms in priming.

Fixed. Using the old style for now. Will rework both alarms to use new persistence when we revisit the dialyzer timeout alarms in priming.

2:51 pm

Michael Garthwaite

DEN-13903: Reworked upper level persistence. Added todo for dialyizer timeout. code review changes.

Options
    • -1
    • +9
    /firmware/App/Controllers/AirTrap.c
    • -13
    • +1
    /firmware/App/Modes/Prime.c
2:47 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:39 pm

Sean Nash

Seems like largest calculated t/o = 38.2 seconds vs. 60 second alarm t/o. Let's leave as is for now, but add a TODO comment here to remove alarm t/o and associated alarm.

Seems like largest calculated t/o = 38.2 seconds vs. 60 second alarm t/o.
Let's leave as is for now, but add a TODO comment here to remove alarm t/o and associated alarm.

2:33 pm

Michael Garthwaite

DEN-13903: addressed code review comments.

Options
    • -2
    • +3
    /firmware/App/Modes/Prime.c
2:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:25 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:25 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:19 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:16 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!