hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
DEN-14150: Update DialInFlow.c

    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
Done. I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLM...

Done.
I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLMin() instead of using filteredDialinFlowMeterReading.

DEN-14150: Update DialInFlow.c

    • -15
    • +18
    /firmware/App/Controllers/DialInFlow.c
This is here so both stacks can use it.

This is here so both stacks can use it.

Done.

Done.

Done. Now use the function getMeasuredDialInFlowRate() instead of using filteredDialinFlowMeterReading.

Done. Now use the function getMeasuredDialInFlowRate() instead of using filteredDialinFlowMeterReading.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14175 merged staging and resolved the conflicts

    • -3
    • +4
    /firmware/App/Controllers/DGInterface.c
    • -3
    • +14
    /firmware/App/Controllers/PresOccl.c
    • -48
    • +155
    /firmware/App/Modes/ModePreTreat.c
    • -76
    • +217
    /firmware/App/Modes/SelfTests.c
DEN-14150: Update DialInFlow.c

    • -1
    • +0
    /firmware/App/Controllers/DialInFlow.c
Removed.

Removed.

I already removed the test code (at line 116). I just checked and it was removed in my local version. I already pushed DEN-14150. Please pull it gain to see if the test code is still there. Thank you.

I already removed the test code (at line 116).
I just checked and it was removed in my local version. I already pushed DEN-14150.
Please pull it gain to see if the test code is still there.
Thank you.

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove blank line.

Remove blank line.

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14175 addressed the code review comments

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Remove test code.

Remove test code.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Remove test code.

Remove test code.

RESOLVED IN CODE WLAKTHROUGH

RESOLVED IN CODE WLAKTHROUGH

Looks like blank line is still there.

Looks like blank line is still there.