hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Nov 2022
12:56 pm

Dara Navaei

DEN-14175 removed a blank line

Options
    • -1
    • +0
    /firmware/App/Controllers/PresOccl.c
8:44 am

Sean Nash

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

8:41 am

Sean Nash

Doesn't this command take a pointer to a structure now?

Doesn't this command take a pointer to a structure now?

Tuesday 08 Nov 2022
2:22 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +2
    /firmware/App/Controllers/SyringePump.h
    • -2
    • +2
    /firmware/App/Modes/SelfTests.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
2:19 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

Options
    • -2
    • +124
    /firmware/App/Controllers/SyringePump.c
    • -5
    • +15
    /firmware/App/Modes/SelfTests.c
2:18 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:18 pm

dcox  (deleted user)

2:13 pm

Sean Nash , wbracken  (deleted user) and Behrouz NematiPour

2:06 pm

Behrouz NematiPour

That was one the best explanations I have ever gotten about one of my confusions. I should have asked this a long time ago. Thanks a lot, Sean. RESOLVED in CODE WALKTHROUGH.

That was one the best explanations I have ever gotten about one of my confusions.
I should have asked this a long time ago.
Thanks a lot, Sean.

RESOLVED in CODE WALKTHROUGH.

12:38 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:18 pm

dcox  (deleted user)

Updated else only with rampSyringePump().

Updated else only with rampSyringePump().

12:01 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into develop

Options
    • -2
    • +124
    /firmware/App/Controllers/SyringePump.c
    • -5
    • +15
    /firmware/App/Modes/SelfTests.c
11:59 am

Darren Cox <darren_m@cox.net>

DEN-14170 Code review comment update for if/else condition.

Options
    • -14
    • +14
    /firmware/App/Controllers/SyringePump.c
9:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:28 am

Dong Nguyen

Removed. Done.

Removed. Done.

9:24 am

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -3
    • +0
    /firmware/App/Controllers/DialInFlow.c
9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:02 am

Sean Nash

Remove extra blank line. Should only be 1 blank line between functions.

Remove extra blank line. Should only be 1 blank line between functions.

8:56 am

Sean Nash

It is not technically a boolean - it is a BOOL which is our implementation of a boolean (TRUE = 1, FALSE = 0). If we don't explicitly compare a BOOL to TRUE, compiler will consider any non-zero val...

It is not technically a boolean - it is a BOOL which is our implementation of a boolean (TRUE = 1, FALSE = 0).
If we don't explicitly compare a BOOL to TRUE, compiler will consider any non-zero value to be TRUE. So if memory is overwritten/corrupted to a random non-zero value, it would satisfy "if ( isSyringePumpPreLoaded() )" and s.w would do the wrong thing.
For extra safety, we prefer to compare to TRUE (1) or FALSE (0) depending on what would be safer.
For example, in this case we are deciding whether to seek plunger or alarm. We only seek plunger if the syringe pump was pre-loaded. It is safer to check pre-loaded flag is TRUE (1) to seek and ANY OTHER VALUE would alarm.
Also, when using the "==" compare operator, we will put the literal first. It looks awkward, but if we accidently use the "=" operator by mistake the compiler will give us a syntax error which saves us from having a tricky bug to fix later.

Monday 07 Nov 2022
6:25 pm

Darren Cox <darren_m@cox.net>

DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

Options
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
2:33 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
2:08 pm

Dong Nguyen

Done. I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLM...

Done.
I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLMin() instead of using filteredDialinFlowMeterReading.

1:51 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -15
    • +18
    /firmware/App/Controllers/DialInFlow.c
11:27 am

Dara Navaei

This is here so both stacks can use it.

This is here so both stacks can use it.

11:27 am

Dara Navaei

Done.

Done.

11:04 am

Dong Nguyen

Done. Now use the function getMeasuredDialInFlowRate() instead of using filteredDialinFlowMeterReading.

Done. Now use the function getMeasuredDialInFlowRate() instead of using filteredDialinFlowMeterReading.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Dara Navaei

DEN-14175 merged staging and resolved the conflicts

Options
    • -3
    • +4
    /firmware/App/Controllers/DGInterface.c
    • -3
    • +14
    /firmware/App/Controllers/PresOccl.c
    • -48
    • +155
    /firmware/App/Modes/ModePreTreat.c
    • -2
    • +2
    /firmware/App/Modes/Prime.c
    • -76
    • +217
    /firmware/App/Modes/SelfTests.c