Activity hdfirmware/

12:56 pm

Dara Navaei

More
fae0fd5
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more HD-DEN-14175-1

Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

- -4
- +126
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -7
- +17
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

12:56 pm

Dara Navaei

More
ccdc42e
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more HD-DEN-14175-1

DEN-14175 removed a blank line

- -1
- +0
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c

8:44 am

Sean Nash

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

8:41 am

Sean Nash

More
Re: HD-DEN-14175-1
commented on review

Doesn't this command take a pointer to a structure now?

2:22 pm

Dara Navaei

More
0b6cb1c
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

2:22 pm

Dara Navaei

More
e482c96
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more HD-DEN-14175-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -2
- +2
/firmware/App/Controllers/SyringePump.h
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.h
- -2
- +2
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -2
- +2
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h

2:19 pm

Darren Cox <darren_m@cox.net>

More
66c6285
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

- -2
- +124
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -5
- +15
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

2:18 pm

Dara Navaei

More
15fa6bf
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

2:18 pm

dcox (deleted user)

More
HD-DEN-14170-1
Closed

2:13 pm

Sean Nash , wbracken (deleted user) and Behrouz NematiPour

More
HD-DEN-14170-1
finished reviewing

2:06 pm

Behrouz NematiPour

More
Re: HD-DEN-14170-1
replied to Sean Nash

That was one the best explanations I have ever gotten about one of my confusions. I should have asked this a long time ago. Thanks a lot, Sean. RESOLVED in CODE WALKTHROUGH.

That was one the best explanations I have ever gotten about one of my confusions.
I should have asked this a long time ago.
Thanks a lot, Sean.

RESOLVED in CODE WALKTHROUGH.

12:38 pm

Sean Nash

More
Re: HD-DEN-14170-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

12:18 pm

dcox (deleted user)

More
Re: HD-DEN-14170-1
replied to Sean Nash

Updated else only with rampSyringePump().

12:01 pm

Darren Cox <darren_m@cox.net>

More
de03955
changed 2 files
develop

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into develop

- -2
- +124
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -5
- +15
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:59 am

Darren Cox <darren_m@cox.net>

More
a5ed2e6
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more HD-DEN-14170-1

DEN-14170 Code review comment update for if/else condition.

- -14
- +14
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

9:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:28 am

Dong Nguyen

More
Re: HD-DEN-14150-1
replied to Sean Nash

Removed. Done.

9:24 am

Dong Nguyen <dnguyen@diality.com>

More
d3e3b81
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more HD-DEN-14150-1

DEN-14150: Update DialInFlow.c

- -3
- +0
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c

9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:02 am

Sean Nash

More
Re: HD-DEN-14150-1
commented on review

Remove extra blank line. Should only be 1 blank line between functions.

8:56 am

It is not technically a boolean - it is a BOOL which is our implementation of a boolean (TRUE = 1, FALSE = 0). If we don't explicitly compare a BOOL to TRUE, compiler will consider any non-zero val...

It is not technically a boolean - it is a BOOL which is our implementation of a boolean (TRUE = 1, FALSE = 0).
If we don't explicitly compare a BOOL to TRUE, compiler will consider any non-zero value to be TRUE. So if memory is overwritten/corrupted to a random non-zero value, it would satisfy "if ( isSyringePumpPreLoaded() )" and s.w would do the wrong thing.
For extra safety, we prefer to compare to TRUE (1) or FALSE (0) depending on what would be safer.
For example, in this case we are deciding whether to seek plunger or alarm. We only seek plunger if the syringe pump was pre-loaded. It is safer to check pre-loaded flag is TRUE (1) to seek and ANY OTHER VALUE would alarm.
Also, when using the "==" compare operator, we will put the literal first. It looks awkward, but if we accidently use the "=" operator by mistake the compiler will give us a syntax error which saves us from having a tricky bug to fix later.

6:25 pm

Darren Cox <darren_m@cox.net>

More
abd31ef
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more HD-DEN-14170-1

DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

- -1
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

2:33 pm

Dong Nguyen <dnguyen@diality.com>

More
1d3672e
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more HD-DEN-14150-1

DEN-14150: Update DialInFlow.c

- -2
- +2
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c

2:08 pm

Dong Nguyen

More
Re: HD-DEN-14150-1
replied to Sean Nash

Done. I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLM...

Done.
I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLMin() instead of using filteredDialinFlowMeterReading.

1:51 pm