Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	10 Jun
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 10 Nov 2022

10:27 am

Dara Navaei

More
54ef95c
changed 2 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more HD-DEN-14175-1

DEN-14175 addressed a code review comment

- -1
- +1
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -1
- +0
/firmware/App/Services/FPGA.h
- History
- Source
- Diff
/firmware/App/Services/FPGA.h

Wednesday 09 Nov 2022

2:18 pm

Dong Nguyen <dnguyen@diality.com>

More
90be435
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 308 more HD-DEN-14150-1

DEN-14150: Update DialInFLow.c

- -6
- +4
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c

1:59 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Dara Navaei

More
a9368b2
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more HD-DEN-14175-1

DEN-14175 addressed the code review comments. Updated the reservoir switch command in pre treatment and added the getHWConfig function in FPGA

- -2
- +6
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -6
- +10
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -1
- +4
/firmware/App/Services/FPGA.h
- History
- Source
- Diff
/firmware/App/Services/FPGA.h

1:23 pm

Dara Navaei

More
Re: HD-DEN-14175-1
replied to Sean Nash

Done.

Done.

1:13 pm

Dara Navaei

More
Re: HD-DEN-14175-1
replied to Sean Nash

Done

Done

1:12 pm

Dara Navaei

More
Re: HD-DEN-14175-1
replied to Sean Nash

Done.

Done.

1:11 pm

Dara Navaei

More
Re: HD-DEN-14175-1
replied to Sean Nash

Done.

Done.

12:56 pm

Dara Navaei

More
fae0fd5
changed 2 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more HD-DEN-14175-1

Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

- -4
- +126
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -7
- +17
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

12:56 pm

Dara Navaei

More
ccdc42e
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more HD-DEN-14175-1

DEN-14175 removed a blank line

- -1
- +0
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c

8:44 am

Sean Nash

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

8:41 am

Sean Nash

More
Re: HD-DEN-14175-1
commented on review

Doesn't this command take a pointer to a structure now?

Doesn't this command take a pointer to a structure now?

Tuesday 08 Nov 2022

2:22 pm

Dara Navaei

More
0b6cb1c
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

2:22 pm

Dara Navaei

More
e482c96
changed 4 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more HD-DEN-14175-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -2
- +2
/firmware/App/Controllers/SyringePump.h
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.h
- -2
- +2
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -2
- +2
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h

2:19 pm

Darren Cox <darren_m@cox.net>

More
66c6285
changed 2 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 309 more

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

- -2
- +124
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -5
- +15
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

2:18 pm

Dara Navaei

More
15fa6bf
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

2:18 pm

dcox (deleted user)

More
HD-DEN-14170-1
Closed

2:13 pm

Sean Nash , wbracken (deleted user) and Behrouz NematiPour

More
HD-DEN-14170-1
finished reviewing

2:06 pm

Behrouz NematiPour

More
Re: HD-DEN-14170-1
replied to Sean Nash

That was one the best explanations I have ever gotten about one of my confusions. I should have asked this a long time ago. Thanks a lot, Sean. RESOLVED in CODE WALKTHROUGH.

That was one the best explanations I have ever gotten about one of my confusions.
I should have asked this a long time ago.
Thanks a lot, Sean.

RESOLVED in CODE WALKTHROUGH.

12:38 pm

Sean Nash

More
Re: HD-DEN-14170-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:18 pm

dcox (deleted user)

More
Re: HD-DEN-14170-1
replied to Sean Nash

Updated else only with rampSyringePump().

Updated else only with rampSyringePump().

12:01 pm

Darren Cox <darren_m@cox.net>

More
de03955
changed 2 files
develop

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into develop

- -2
- +124
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -5
- +15
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:59 am

Darren Cox <darren_m@cox.net>

More
a5ed2e6
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 310 more HD-DEN-14170-1

DEN-14170 Code review comment update for if/else condition.

- -14
- +14
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

9:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:28 am

Dong Nguyen

More
Re: HD-DEN-14150-1
replied to Sean Nash

Removed. Done.

Removed. Done.

9:24 am

Dong Nguyen <dnguyen@diality.com>

More
d3e3b81
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 308 more HD-DEN-14150-1

DEN-14150: Update DialInFlow.c

- -3
- +0
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-18 00:47 -0700