hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 28 Nov 2022
1:16 pm

Michael Garthwaite

DEN-14344: fixed pin configuration for air pump.

Options
    • -1
    • +1
    /firmware/App/Controllers/AirPump.c
    • -1
    • +1
    /firmware/HD.dil
12:33 pm

dcox  (deleted user)

Updated to reset valve position and flag.

Updated to reset valve position and flag.

12:32 pm

dcox  (deleted user)

Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is neces...

Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is necessary.

12:30 pm

dcox  (deleted user)

Updated to venous. Good catch.

Updated to venous. Good catch.

12:29 pm

Darren Cox <darren_m@cox.net>

DEN-14099 Code review comment updates 1.

Options
    • -2
    • +6
    /firmware/App/Modes/Prime.c
11:49 am

Michael Garthwaite

DEN-14344: air pump updates. changed halcogen code. removed some unused code. removed getairpumpmotorstate.

Options
    • -14
    • +4
    /firmware/App/Controllers/AirPump.c
    • -3
    • +3
    /firmware/HD.dil
    • -1
    • +1
    /firmware/include/het.h
    • -1
    • +1
    /firmware/source/het.c
Wednesday 23 Nov 2022
1:19 pm

wbracken  (deleted user)

AirPump.h should be before AirTrap.h.

AirPump.h should be before AirTrap.h.

9:28 am

Michael Garthwaite

Function removed. Thanks!

Function removed. Thanks!

9:27 am

Michael Garthwaite

Function Removed. Thanks!

Function Removed. Thanks!

9:27 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:27 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:27 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:26 am

Michael Garthwaite

Function removed. Thanks!

Function removed. Thanks!

9:26 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:26 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

DEN-14344: Air Pump updates. moved to task general. removal of monitor functions. code review changes. Reworked setting motor to be more direct while debugging.

Options
    • -50
    • +10
    /firmware/App/Controllers/AirPump.c
    • -9
    • +14
    /firmware/App/Controllers/AirPump.h
    • -0
    • +3
    /firmware/App/Tasks/TaskGeneral.c
    • -0
    • +2
    /firmware/source/sys_main.c
9:19 am

Michael Garthwaite

Do we have an alternative to reading if we successfully set the pin high/low?

Do we have an alternative to reading if we successfully set the pin high/low?

Tuesday 22 Nov 2022
4:21 pm

Dara Navaei

HD-DEN-14252_System Self Test Failure Occurs Intermittently
HD-DEN-14252_System Self Test Failure Occurs Intermittently
3:52 pm

Michael Garthwaite

please fix naming. comment says arterial but define is calling it as venous.

please fix naming. comment says arterial but define is calling it as venous.

9:40 am

Sean Nash

Ok. Not sure how HALCoGen got ahead of generated code for a time. RESOLVED in CODE WALKTHROUGH.

Ok. Not sure how HALCoGen got ahead of generated code for a time.
RESOLVED in CODE WALKTHROUGH.

9:30 am

Sean Nash

Oh, ok. Then somebody removed a blank line previously and should not have. RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have.
RESOLVED in CODE WALKTHROUGH.

9:27 am

Sean Nash

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump direc...

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump directly.

9:25 am

Sean Nash

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

9:24 am

Sean Nash

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

9:22 am

Sean Nash

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

9:21 am

Sean Nash

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.