hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14344: fixed pin configuration for air pump.

Updated to reset valve position and flag.

Updated to reset valve position and flag.

Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is neces...

Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is necessary.

Updated to venous. Good catch.

Updated to venous. Good catch.

DEN-14099 Code review comment updates 1.

DEN-14344: air pump updates. changed halcogen code. removed some unused code. removed getairpumpmotorstate.

    • -14
    • +4
    /firmware/App/Controllers/AirPump.c
AirPump.h should be before AirTrap.h.

AirPump.h should be before AirTrap.h.

Function removed. Thanks!

Function removed. Thanks!

Function Removed. Thanks!

Function Removed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Function removed. Thanks!

Function removed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

DEN-14344: Air Pump updates. moved to task general. removal of monitor functions. code review changes. Reworked setting motor to be more direct while debugging.

    • -50
    • +10
    /firmware/App/Controllers/AirPump.c
    • -9
    • +14
    /firmware/App/Controllers/AirPump.h
Do we have an alternative to reading if we successfully set the pin high/low?

Do we have an alternative to reading if we successfully set the pin high/low?

HD-DEN-14252_System Self Test Failure Occurs Intermittently
HD-DEN-14252_System Self Test Failure Occurs Intermittently
please fix naming. comment says arterial but define is calling it as venous.

please fix naming. comment says arterial but define is calling it as venous.

Ok. Not sure how HALCoGen got ahead of generated code for a time. RESOLVED in CODE WALKTHROUGH.

Ok. Not sure how HALCoGen got ahead of generated code for a time.
RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have. RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have.
RESOLVED in CODE WALKTHROUGH.

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump direc...

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump directly.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.