hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN_14252: Addressed code review comment.

Where did this enum name change take place? There is no common in this code review.

Where did this enum name change take place? There is no common in this code review.

remove "," after pwm.

remove "," after pwm.

Remove blank line.

Remove blank line.

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

Remove blank line.

Remove blank line.

First part of condition should have () around it too. Do we want to set direction here even if we fail to satisfy condition below?

First part of condition should have () around it too.
Do we want to set direction here even if we fail to satisfy condition below?

Keep a blank line between declaration and code.

Keep a blank line between declaration and code.

Not clear on what this refactoring of condition changed - looks the same.

Not clear on what this refactoring of condition changed - looks the same.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252: Another fix to pre-tx reservor mgmt state machine.

Auto stash before merge of "develop" and "origin/develop"

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Resolved a message ID name change in develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252: Additional fix to reservoir mgmt state machine.

parameter0?

parameter0?

Please add comment.

Please add comment.

HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

    • -1
    • +0
    /firmware/App/Controllers/DGInterface.c
DEN-14252 updated the getDGCommandResponse to not set the command ID to none until the command is done

    • -1
    • +0
    /firmware/App/Controllers/DGInterface.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252 updated the pretreatment reservoirs state change condition and added the HD load cels events

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merged DEN-14252

    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -17
    • +19
    /firmware/App/Modes/ModeStandby.c