hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Dec 2022
4:36 pm

Sean Nash

DEN_14252: Addressed code review comment.

Options
    • -1
    • +2
    /firmware/App/Modes/Prime.c
4:24 pm

Sean Nash

Where did this enum name change take place? There is no common in this code review.

Where did this enum name change take place? There is no common in this code review.

4:22 pm

Sean Nash

remove "," after pwm.

remove "," after pwm.

4:22 pm

Sean Nash

Remove blank line.

Remove blank line.

4:21 pm

Sean Nash

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

4:19 pm

Sean Nash

Remove blank line.

Remove blank line.

4:19 pm

Sean Nash

First part of condition should have () around it too. Do we want to set direction here even if we fail to satisfy condition below?

First part of condition should have () around it too.
Do we want to set direction here even if we fail to satisfy condition below?

4:15 pm

Sean Nash

Keep a blank line between declaration and code.

Keep a blank line between declaration and code.

4:14 pm

Sean Nash

Not clear on what this refactoring of condition changed - looks the same.

Not clear on what this refactoring of condition changed - looks the same.

2:18 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:18 pm

Dara Navaei

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
2:14 pm

Sean Nash

DEN-14252: Another fix to pre-tx reservor mgmt state machine.

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
1:45 pm

Michael Garthwaite

Auto stash before merge of "develop" and "origin/develop"

Options
    • -0
    • +1
    /firmware/App/Controllers/AirPump.c
12:56 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
12:55 pm

Dara Navaei

Resolved a message ID name change in develop

Options
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
12:07 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
12:07 pm

Dara Navaei

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
12:03 pm

Sean Nash

DEN-14252: Additional fix to reservoir mgmt state machine.

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
11:49 am

wbracken  (deleted user)

parameter0?

parameter0?

10:55 am

Dara Navaei

Please add comment.

Please add comment.

10:52 am

Dara Navaei

HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
9:37 am

jtaylor  (deleted user)

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

9:33 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
9:33 am

Dara Navaei

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

Options
    • -1
    • +0
    /firmware/App/Controllers/DGInterface.c
9:32 am

Dara Navaei

DEN-14252 updated the getDGCommandResponse to not set the command ID to none until the command is done

Options
    • -1
    • +0
    /firmware/App/Controllers/DGInterface.c
Thursday 01 Dec 2022
6:15 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
6:14 pm

Dara Navaei

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

Options
    • -1
    • +4
    /firmware/App/Modes/ModePreTreat.c
6:13 pm

Dara Navaei

DEN-14252 updated the pretreatment reservoirs state change condition and added the HD load cels events

Options
    • -4
    • +9
    /firmware/App/Modes/Dialysis.c
    • -1
    • +4
    /firmware/App/Modes/ModePreTreat.c
2:48 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:35 pm

Dara Navaei

Merged DEN-14252

Options
    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -11
    • +8
    /firmware/App/Modes/ModePreTreat.c
    • -17
    • +19
    /firmware/App/Modes/ModeStandby.c
    • -3
    • +1
    /firmware/App/Modes/Prime.c
    • -0
    • +6
    /firmware/App/Modes/SelfTests.c