hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14086: Addressed code review comments.

    • -3
    • +6
    /firmware/App/Controllers/DialInFlow.c
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Assignment alignment.

Assignment alignment.

FALSE was correct (throughout) for last param of sendAckResponseMsg() if message/request found to be invalid in some way, TRUE if message is ok.

FALSE was correct (throughout) for last param of sendAckResponseMsg() if message/request found to be invalid in some way, TRUE if message is ok.

Assignment alignment in module.

Assignment alignment in module.

Assignment statement alignment

Assignment statement alignment

Assignment statements.

Assignment statements.

Alignment of what?

Alignment of what?

Not clear what you mean.

Not clear what you mean.

DEN-14086: Removed obsolete DPi flow vs. motor speed check and alarm.

    • -35
    • +3
    /firmware/App/Controllers/DialInFlow.c
Alignment throughout module and function header.

Alignment throughout module and function header.

Timer variable is actually a time stamp of last command being queued - variable name could be clearer.

Timer variable is actually a time stamp of last command being queued - variable name could be clearer.

Alignment

Alignment

Alignment

Alignment

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-14086-alarm-159-dialysate-inlet-pump-failed-flow-vs-motor-speed-check' into develop

    • -3
    • +3
    /firmware/App/Controllers/DialInFlow.c
DEN-14086: Change what gets logged with alarm 159 to assist in debugging false alarm.

    • -3
    • +3
    /firmware/App/Controllers/DialInFlow.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Fixed merge conflicts.

    • -1
    • +1
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -22
    • +6
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +2
    /firmware/App/Controllers/Temperatures.c
    • -1
    • +1
    /firmware/App/Modes/ConsumableSelfTest.c
  1. … 3 more files in changeset.
DEN-14086: Increased de-prime time from 30 to 40 sec to allow for some pull-back during pump homing. Delay betweem end of no cartridge pump test and request to home pumps.

    • -19
    • +3
    /firmware/App/Controllers/DialInFlow.c
    • -19
    • +20
    /firmware/App/Modes/ModePostTreat.c
HD-DEN-14086_Alarm 159 Dialysate Inlet Pump Failed Flow VS Motor Speed Check
HD-DEN-14086_Alarm 159 Dialysate Inlet Pump Failed Flow VS Motor Speed Check
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' into DEN-14344-sw-s85-mg-air-pump

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Controllers/Temperatures.c