Activity hdfirmware/

1:05 pm

James Walter Taylor <jtaylor@diality.com>

More
4e60931
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more HD-DEN-14561-1

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

Corrected _RELEASE_ logic, release build executes the same block as non debug selection

- -3
- +3
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -1
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -3
- +3
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -10
- +11
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c

1:04 pm

Sean Nash

More
Re: HD-DEN-14549-1
replied to dcox (deleted user)

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

12:13 pm

dcox (deleted user)

More
Re: HD-DEN-14549-1
commented on review

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

11:35 am

Sean Nash

More
Re: HD-DEN-14549-1
replied to wbracken (deleted user)

Done.

11:35 am

Sean Nash

More
843fdb5
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 285 more HD-DEN-14549-1

DEN-14549: Addressed code review comments.

- -3
- +3
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:32 am

Sean Nash

More
Re: HD-DEN-14549-1
replied to wbracken (deleted user)

Done.

11:32 am

Sean Nash

More
Re: HD-DEN-14549-1
replied to wbracken (deleted user)

Done.

11:19 am

Sean Nash

More
81c902f
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 285 more HD-DEN-14549-1

DEN-14549: maintain blood flow rate when alarm w/ blood recirc property pauses treatment. maintain Heparin dispense when blood recirc is occurring during alarm pause of treatment. include blood prime state in checks for inline pressure range.

- -24
- +4
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -3
- +1
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -0
- +1
/firmware/App/Modes/Dialysis.h
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.h
- -18
- +24
/firmware/App/Modes/TreatmentStop.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentStop.c

11:01 am

Dara Navaei

More
HD-DEN-14328-1
started review

HD-DEN-14328_HD Event Issues

9:57 am

wbracken (deleted user)

More
Re: HD-DEN-14549-1
commented on review

Add pressureSelfTestNormalizedStartTime to header.

9:55 am

wbracken (deleted user)

More
Re: HD-DEN-14549-1
commented on review

Add pressureSelfTestPreNormalStartTime to header.

9:54 am

wbracken (deleted user)

More
Re: HD-DEN-14549-1
commented on review

Add pressureSelfTestPreNormalStartTime to header.

9:44 am

wbracken (deleted user)

More
Re: HD-DEN-14549-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

9:30 am

Sean Nash

More
ed4d9f0
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 285 more HD-DEN-14549-1

DEN-14549: Misc updates to dry self-tests in pre-treatment.

- -3
- +3
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -34
- +59
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -8
- +3
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

3:56 pm

James Walter Taylor <jtaylor@diality.com>

More
2d1982b
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more

Merge branch 'DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off' into DEN-14561-_release_-preprocessor-flag-specifies-code-that-conflicts-with-sw_config_-debug

3:50 pm

James Walter Taylor <jtaylor@diality.com>

More
72186ef
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more HD-DEN-14561-1

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off

Reverted volume changes. Using a lower volume appeared to cause flowmeter test errors. Volumes match the original code, now.

- -6
- +7
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c

3:01 pm

Dara Navaei

More
HD-DEN-14561-1
started review

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

2:15 pm

Sean Nash

More
949b386
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 285 more HD-DEN-14549-1

DEN-14549: Fixed issue where door open alarm would have condition cleared repeatedly in standby start state. Made top alarm determination done from scratch each time.