hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Jan 2023
1:12 pm

Sean Nash

Fixed merge conflicts from staging.

Options
    • -1
    • +2
    /firmware/App/Controllers/Valves.c
1:06 pm

Sean Nash

Merge branch 'staging' into DEN-14549-system-fault-after-resuming-heparin-then-starting-saline-bolus-during-treatment

Options
    • -12
    • +12
    /firmware/App/Modes/ModeInitPOST.c
    • -21
    • +5
    /firmware/App/Modes/SelfTests.c
    • -5
    • +7
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.h
12:38 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:21 pm

Sean Nash

DEN-14549: Added function to see if an alarm condition is detected. Added a function to determine whether A/C power loss condition is detected and used them where needed.

Options
    • -2
    • +3
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +4
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +3
    /firmware/App/Controllers/DialOutFlow.c
    • -0
    • +21
    /firmware/App/Drivers/Battery.c
    • -0
    • +1
    /firmware/App/Drivers/Battery.h
    • -1
    • +38
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
11:58 am

Sean Nash

DEN-14549: include venous check in including blood prime.

Options
    • -2
    • +5
    /firmware/App/Controllers/PresOccl.c
11:55 am

dcox  (deleted user)

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

11:53 am

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:51 am

Sean Nash

DEN-14549: Addressed code review comments.

Options
    • -1
    • +11
    /firmware/App/Controllers/Voltages.c
    • -1
    • +1
    /firmware/App/Drivers/Battery.c
11:50 am

Sean Nash

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

11:48 am

Sean Nash

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

11:15 am

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:13 am

dcox  (deleted user)

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

11:08 am

dcox  (deleted user)

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

10:17 am

Sean Nash

DEN-14549: clear treatment version of ac power loss alarm too when ac is restored. prevent pump current alarms when ac power loss in treatment is active too.

Options
    • -1
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
    • -0
    • +1
    /firmware/App/Drivers/Battery.c
9:57 am

Sean Nash

DEN-14549: ensure air pump is off at start of prime state in pre-tx.

Options
    • -0
    • +6
    /firmware/App/Modes/Prime.c
9:41 am

Sean Nash

DEN-14549: removed unneccessary pre-tx prime state.

Options
    • -17
    • +13
    /firmware/App/Modes/Prime.c
Tuesday 17 Jan 2023
3:53 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off dragged into current branch

Options
    • -4
    • +4
    /firmware/App/Modes/ModePreTreat.c
2:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:57 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:25 pm

dcox  (deleted user)

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

1:55 pm

James Walter Taylor <jtaylor@diality.com>

Merge branch 'staging' into DEN-14561-_release_-preprocessor-flag-specifies-code-that-conflicts-with-sw_config_-debug

Options
1:05 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

Corrected _RELEASE_ logic, release build executes the same block as non debug selection

Options
    • -3
    • +3
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -3
    • +3
    /firmware/App/Modes/SelfTests.c
    • -10
    • +11
    /firmware/App/Services/AlarmMgmt.c
1:04 pm

Sean Nash

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

12:13 pm

dcox  (deleted user)

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

11:35 am

Sean Nash

Done.

Done.

11:35 am

Sean Nash

DEN-14549: Addressed code review comments.

Options
    • -3
    • +3
    /firmware/App/Modes/SelfTests.c
11:32 am

Sean Nash

Done.

Done.

11:32 am

Sean Nash

Done.

Done.

11:19 am

Sean Nash

DEN-14549: maintain blood flow rate when alarm w/ blood recirc property pauses treatment. maintain Heparin dispense when blood recirc is occurring during alarm pause of treatment. include blood prime state in checks for inline pressure range.

Options
    • -24
    • +4
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +1
    /firmware/App/Modes/Dialysis.c
    • -0
    • +1
    /firmware/App/Modes/Dialysis.h
    • -18
    • +24
    /firmware/App/Modes/TreatmentStop.c