hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Jan 2023
1:28 pm

Michael Garthwaite

DEN-14011: implemented proper exit condition for dry self start state.

Options
    • -0
    • +12
    /firmware/App/Modes/SelfTests.c
12:38 pm

jtaylor  (deleted user)

Done.

Done.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:36 am

Sean Nash

Do we need an else where we reset 10 second start time (if latch opened)?

Do we need an else where we reset 10 second start time (if latch opened)?

11:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:29 am

Michael Garthwaite

Fixed. Created handleDrySelfTestStartState() that counts settle time once the latch is determined closed.

Fixed. Created handleDrySelfTestStartState() that counts settle time once the latch is determined closed.

11:28 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

11:27 am

Michael Garthwaite

Fixed. Only checking if BP is running when are in treatment mode.

Fixed. Only checking if BP is running when are in treatment mode.

11:27 am

Michael Garthwaite

DEN-14011: created handleDrySelfTestStartState. code review comments.

Options
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -20
    • +40
    /firmware/App/Modes/SelfTests.c
10:36 am

dcox  (deleted user)

Updated to 600.

Updated to 600.

10:30 am

Darren Cox <darren_m@cox.net>

DEN-14561 Update PRE_TREATMENT_FILL_RESERVOIR_TWO_VOLUME_ML per code review comment.

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
9:13 am

Sean Nash

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

9:11 am

Sean Nash

Should this 10 seconds only start once latch is locked?

Should this 10 seconds only start once latch is locked?

9:07 am

Sean Nash

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

Thursday 19 Jan 2023
3:47 pm

Sean Nash

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

3:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:33 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
3:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Modes/ConsumableSelfTest.c
    • -2
    • +2
    /firmware/App/Modes/Dialysis.c
    • -2
    • +2
    /firmware/App/Modes/ModePostTreat.c
    • -2
    • +2
    /firmware/App/Modes/ModeTreatmentParams.c
    • -2
    • +2
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -2
    • +2
    /firmware/App/Modes/Prime.c
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
    • -2
    • +2
    /firmware/App/Modes/SampleWater.c
    • -2
    • +2
    /firmware/App/Modes/SelfTests.c
    • -2
    • +2
    /firmware/App/Modes/TreatmentEnd.c
    • -2
    • +2
    /firmware/App/Modes/TreatmentRecirc.c
    • -2
    • +2
    /firmware/App/Modes/TreatmentStop.c
3:31 pm

Michael Garthwaite

Merge branch 'DEN-14328-hd-event-issues' into staging

Options
3:30 pm

Michael Garthwaite

3:16 pm

Dara Navaei

HD-DEN-14011_Occulsion Alarm When Reseating
HD-DEN-14011_Occulsion Alarm When Reseating
3:12 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:01 pm

Michael Garthwaite

DEN-14011: added condition to check if BP is running while we do occlusion checks.

Options
    • -3
    • +5
    /firmware/App/Controllers/PresOccl.c
1:50 pm

Sean Nash and Dara Navaei

1:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:49 pm

Michael Garthwaite

DEN-14011: dry self test transitions to DRY_SELF_TESTS_START_STATE on dry self retries instead of DRY_SELF_WAIT_FOR_DOOR_CLOSE_STATE.

Options
    • -1
    • +1
    /firmware/App/Modes/SelfTests.c
1:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.