hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Feb 2023
1:55 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/Voltages.c
1:02 pm

wbracken  (deleted user) and Sean Nash

12:48 pm

Dara Navaei

DEN-14604 added code to not trigger the AC power loss if the safefy shutdown is enabled

Options
    • -5
    • +9
    /firmware/App/Controllers/Voltages.c
10:59 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:58 am

Michael Garthwaite

DEN-14589: fixed syringe pump events.

Options
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
9:47 am

Sean Nash

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds. Generalize the math. Suggested approach: -integrate vol...

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:47 am

Sean Nash

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement bel...

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement below (now that transfer time was reduced to 30 sec).
Let's generalize this math to clarify it and make it work regardless of time.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:27 am

Dara Navaei

Merge branch 'staging' into DEN-14604-dg_hd_dev-hd_dg_dvt-update-part-9

Options
Thursday 02 Feb 2023
5:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:05 pm

Sean Nash

Do we understand why this is needed?

Do we understand why this is needed?

3:45 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
3:45 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/AirPump.c
    • -2
    • +2
    /firmware/App/Controllers/AirTrap.c
    • -1
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +2
    /firmware/App/Controllers/BloodLeak.c
    • -2
    • +2
    /firmware/App/Controllers/Bubble.c
    • -2
    • +2
    /firmware/App/Controllers/Buttons.c
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +2
    /firmware/App/Controllers/DGInterface.h
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
    • -2
    • +2
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Controllers/Voltages.c
    • -1
    • +1
    /firmware/App/Drivers/Battery.c
  16. … 32 more files in changeset.
2:15 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:09 pm

wbracken  (deleted user) and dcox  (deleted user)

2:02 pm

Sean Nash

Fixed merge conflicts. Re-applied recently rolled back pre-tx state changes.

Options
    • -2
    • +3
    /firmware/App/Controllers/BloodFlow.c
    • -62
    • +38
    /firmware/App/Controllers/DGInterface.c
    • -3
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -2
    • +4
    /firmware/App/Controllers/DialInFlow.c
    • -42
    • +21
    /firmware/App/Controllers/PresOccl.c
    • -2
    • +2
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +23
    /firmware/App/Drivers/Battery.c
    • -11
    • +8
    /firmware/App/Modes/ConsumableSelfTest.c
    • -27
    • +31
    /firmware/App/Modes/ModePreTreat.c
    • -45
    • +63
    /firmware/App/Modes/ModeStandby.c
    • -28
    • +31
    /firmware/App/Modes/Prime.c
    • -70
    • +91
    /firmware/App/Modes/SelfTests.c
    • -16
    • +55
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -12
    • +31
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +4
    /firmware/App/Services/SystemCommMessages.h
12:00 pm

Sean Nash

DEN-14549: Fixed merge from staging merge conflicts.

Options
    • -2
    • +2
    /firmware/App/Controllers/BloodLeak.c
    • -1
    • +13
    /firmware/App/Controllers/Buttons.c
    • -5
    • +7
    /firmware/App/Controllers/PresOccl.c
    • -11
    • +50
    /firmware/App/Controllers/Valves.c
    • -2
    • +14
    /firmware/App/Drivers/SafetyShutdown.c
    • -2
    • +9
    /firmware/App/Modes/ConsumableSelfTest.c
    • -2
    • +21
    /firmware/App/Modes/Dialysis.c
    • -4
    • +16
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +15
    /firmware/App/Modes/ModePostTreat.c
    • -2
    • +8
    /firmware/App/Modes/ModeTreatmentParams.c
    • -2
    • +9
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -2
    • +9
    /firmware/App/Modes/Prime.c
    • -2
    • +8
    /firmware/App/Modes/Rinseback.c
    • -2
    • +9
    /firmware/App/Modes/SampleWater.c
    • -27
    • +82
    /firmware/App/Modes/SelfTests.c
  16. … 3 more files in changeset.
10:32 am

jtaylor  (deleted user)

Done.

Done.

10:31 am

James Walter Taylor <jtaylor@diality.com>

DEN-14561 Comments

Answered comments from code review

Options
    • -3
    • +3
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +2
    /firmware/App/Modes/SelfTests.c
10:30 am

jtaylor  (deleted user)

Done.

Done.

Wednesday 01 Feb 2023
4:44 pm

wbracken  (deleted user)

#define?

#define?

4:14 pm

wbracken  (deleted user)

Alignment

Alignment

4:13 pm

Michael Garthwaite

DEN-14556: updated alarm pressure occlusion alarm to 3s. HD now sends events when occlusion baseline is set. Alarm id 142 and 277 now send baseline occlusion value and trigger value.

Options
    • -4
    • +6
    /firmware/App/Controllers/PresOccl.c
4:09 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 - returned useLastTrimmerHeaterDC logic

checkpoint, correction.

Options
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.c
3:41 pm

Michael Garthwaite

DEN-14589: implemented event for syringe pump state changes.

Options
    • -0
    • +6
    /firmware/App/Controllers/SyringePump.c