Activity hdfirmware/

12:56 pm

Dara Navaei

More
ee529d7
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

12:55 pm

Dara Navaei

More
ceeba51
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more HD-DEN-14561-1 HD-DEN-14589-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -2
- +2
/firmware/App/Controllers/SyringePump.h
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.h
- -1
- +1
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +1
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -1
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -1
- +1
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -0
- +16
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

12:54 pm

Darren Cox <darren_m@cox.net>

More
fae0f1d
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more HD-DEN-14561-1

DEN-14561 Updated for code review comments.

- -1
- +0
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -9
- +8
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c

3:11 pm

Sean Nash

More
3b0b736
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 283 more

Merge branch 'staging' into DEN-14749-syringe-pump-plunger-remains-extended-during-pretreatment-causing-hd-software-fault

2:51 pm

Sean Nash

More
9e1b9e3
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 283 more HD-DEN-14749-1

DEN-14749: Reset preload flag in standby mode instead of after retract/seek/prime operations. Increase alarm threshold for FMD vs. LC check in wet s.t. from 5% to 10%. Refactor alarm audio and 1 minute min tx time config flags. Removed test code in reservoir code.

- -3
- +12
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -0
- +1
/firmware/App/Controllers/SyringePump.h
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.h
- -0
- +1
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -15
- +14
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -1
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -2
- +2
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -31
- +7
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

6:37 pm

Sean Nash

More
Re: HD-DEN-14561-1
commented on review

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

6:15 pm

Sean Nash

More
HD-DEN-14549-1
Closed

3:05 pm

Darren Cox <darren_m@cox.net>

More
e4f34f8
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more HD-DEN-14561-1

DEN-1561 Fix integrated volume calculation for reservoir transfers.

- -5
- +2
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

3:01 pm

Dara Navaei

More
HD-DEN-14749-1
started review

HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault

3:01 pm

Dara Navaei

More
HD-DEN-14763-1
started review

HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10

2:01 pm

Dara Navaei

More
HD-DEN-14604-1
Closed

1:56 pm

Dara Navaei

More
65bb387
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 283 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

1:55 pm

Dara Navaei

More
6544fd4
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 283 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/Voltages.c
- History
- Source
- Diff
/firmware/App/Controllers/Voltages.c

1:02 pm

wbracken (deleted user) and Sean Nash

More
HD-DEN-14604-1
finished reviewing

12:48 pm

Dara Navaei

More
78a4a6b
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 284 more HD-DEN-14604-1

DEN-14604 added code to not trigger the AC power loss if the safefy shutdown is enabled

- -5
- +9
/firmware/App/Controllers/Voltages.c
- History
- Source
- Diff
/firmware/App/Controllers/Voltages.c

10:59 am

wbracken (deleted user)

More
Re: HD-DEN-14561-1
replied to jtaylor (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:58 am

Michael Garthwaite

More
06b1c05
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 277 more HD-DEN-14589-1

DEN-14589: fixed syringe pump events.

- -1
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

9:47 am

Sean Nash

More
Re: HD-DEN-14561-1
commented on review

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds. Generalize the math. Suggested approach: -integrate vol...

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:47 am

Sean Nash

More
Re: HD-DEN-14561-1
commented on review

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement bel...

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement below (now that transfer time was reduced to 30 sec).
Let's generalize this math to clarify it and make it work regardless of time.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:27 am