hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Feb 2023
4:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:12 pm

Michael Garthwaite

it was a double include anyway. Fixed. Thanks!

it was a double include anyway. Fixed. Thanks!

1:50 pm

wbracken  (deleted user)

Alphabetical ordering.

Alphabetical ordering.

12:54 pm

Sean Nash

Saturday 04 Feb 2023
6:37 pm

Sean Nash

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

6:15 pm

Sean Nash

Friday 03 Feb 2023
3:01 pm

Dara Navaei

HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
3:01 pm

Dara Navaei

HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
2:01 pm

Dara Navaei

1:02 pm

wbracken  (deleted user) and Sean Nash

10:59 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:47 am

Sean Nash

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds. Generalize the math. Suggested approach: -integrate vol...

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:47 am

Sean Nash

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement bel...

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement below (now that transfer time was reduced to 30 sec).
Let's generalize this math to clarify it and make it work regardless of time.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

Thursday 02 Feb 2023
5:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:05 pm

Sean Nash

Do we understand why this is needed?

Do we understand why this is needed?

2:09 pm

wbracken  (deleted user) and dcox  (deleted user)

10:32 am

jtaylor  (deleted user)

Done.

Done.

10:30 am

jtaylor  (deleted user)

Done.

Done.

Wednesday 01 Feb 2023
4:44 pm

wbracken  (deleted user)

#define?

#define?

4:14 pm

wbracken  (deleted user)

Alignment

Alignment

11:52 am

jtaylor  (deleted user)

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Tuesday 31 Jan 2023
6:05 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:01 pm

Dara Navaei

HD-DEN-14547_Incorrect DG Event
HD-DEN-14547_Incorrect DG Event
3:45 pm

jtaylor  (deleted user)

Done. We will want to verify that we don't disable all of the resume fill calls.

Done. We will want to verify that we don't disable all of the resume fill calls.