hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Feb 2023
4:52 pm

Michael Garthwaite

DEN-14537: code review comment

Options
    • -1
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.c
4:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:00 pm

Darren Cox <darren_m@cox.net>

DEN-14561 Code review comment update.

Options
    • -1
    • +1
    /firmware/App/Modes/SelfTests.c
3:52 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:40 pm

Darren Cox <darren_m@cox.net>

DEN-14561 Code review comment update.

Options
    • -2
    • +4
    /firmware/App/Modes/ModeTreatment.c
3:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:26 pm

jtaylor  (deleted user)

Done (By Darren).

Done (By Darren).

3:25 pm

jtaylor  (deleted user)

Done.

Done.

3:24 pm

jtaylor  (deleted user)

Done.

Done.

3:24 pm

jtaylor  (deleted user)

This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.

This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.

3:21 pm

jtaylor  (deleted user)

This works, even if the s.t. dry test is skipped.

This works, even if the s.t. dry test is skipped.

3:17 pm

jtaylor  (deleted user)

Done (By Darren)

Done (By Darren)

3:17 pm

jtaylor  (deleted user)

The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.

The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.

3:14 pm

jtaylor  (deleted user)

Done.

Done.

3:12 pm

jtaylor  (deleted user)

Done (by Darren)

Done (by Darren)

3:08 pm

jtaylor  (deleted user)

Comment Alignment

Comment Alignment

3:04 pm

wbracken  (deleted user)

Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,

Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,

3:01 pm

Dara Navaei

HD-DEN-14310_Unable Resume After HD Unit Plugged Back IN
HD-DEN-14310_Unable Resume After HD Unit Plugged Back IN
1:53 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:52 pm

wbracken  (deleted user)

1:52 pm

Michael Garthwaite

DEN-14547: Code review comments

Options
    • -3
    • +3
    /firmware/App/Modes/PreTreatmentRecirc.c
11:58 am

dcox  (deleted user)

Use SEC_PER_MIN instead of 60. Also comment says min, but really it is ms.

Use SEC_PER_MIN instead of 60. Also comment says min, but really it is ms.

11:49 am

Sean Nash

DEN-14561: Set critical data values for UF and Tx duration settings when changed in mid-treatment.

Options
    • -0
    • +4
    /firmware/App/Modes/ModeTreatment.c