hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14561: Fix to pre-tx reservoir mgmt to keep modes from competing w/ res mgmt state machine for control of the active reservoir.

    • -16
    • +49
    /firmware/App/Modes/ModePreTreat.c
Fixed. Thanks!

Fixed. Thanks!

DEN-14537: code review comment

    • -1
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14561 Code review comment update.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14561 Code review comment update.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done (By Darren).

Done (By Darren).

Done.

Done.

Done.

Done.

This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.

This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.

This works, even if the s.t. dry test is skipped.

This works, even if the s.t. dry test is skipped.

Done (By Darren)

Done (By Darren)

The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.

The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.

Done.

Done.

Done (by Darren)

Done (by Darren)

Comment Alignment

Comment Alignment

Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,

Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,

HD-DEN-14310_Unable Resume After HD Unit Plugged Back IN
HD-DEN-14310_Unable Resume After HD Unit Plugged Back IN
Fixed. Thanks!

Fixed. Thanks!

DEN-14547: Code review comments

    • -3
    • +3
    /firmware/App/Modes/PreTreatmentRecirc.c