hdfirmware

Clone Tools

Stats

Commits this week: 9
Total Committers: 17
Last Commit: 11 May
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Feb 2023
11:04 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.h
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
2:39 pm

Sean Nash

2:38 pm

Sean Nash

Merge branch 'staging' into DEN-14790-alarm-199-occurs-intermittently-during-blood-prime-and-treatment

Options
2:38 pm

Sean Nash , Dara Navaei and Michael Garthwaite

2:05 pm

Dara Navaei

2:05 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
2:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Services/SystemComm.c
1:00 pm

Dara Navaei

Merge branch 'staging' into DEN-14781-alarm-117-dg-can-message-not-acked

Options
12:01 pm

Dara Navaei

HD-DEN-14790_Alarm 199 Occurs Intermittently During Blood Prime And Treatment
HD-DEN-14790_Alarm 199 Occurs Intermittently During Blood Prime And Treatment
11:48 am

Michael Garthwaite

Merge branch 'DEN-14459-air-trap-fill-alarm-not-triggering' into develop

Options
11:48 am

Michael Garthwaite

Merge branch 'staging' into DEN-14689-messaging-bugs

Options
11:47 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
11:43 am

Sean Nash

DEN-14790: Changed dialysate recirculation rate from 100 to 250 mL/min to add margin for minimum flow for heating.

Options
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.h
    • -3
    • +1
    /firmware/App/Modes/ModePreTreat.c
11:40 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
11:40 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/AirTrap.c
11:38 am

Michael Garthwaite

11:01 am

Sean Nash and Dara Navaei

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:47 am

Michael Garthwaite

Merge branch 'DEN-14459-air-trap-fill-alarm-not-triggering' into staging

Options
10:46 am

Michael Garthwaite

DEN-14459: code review comments

Options
    • -2
    • +7
    /firmware/App/Controllers/AirTrap.c
10:46 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:34 am

Sean Nash

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer ...

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer to reset things on entry (i.e. line 359 above).

10:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Michael Garthwaite

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other mode...

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other modes of operation. This counter is specifically here to hold the air pump on 100ms after upper level is detecting air. Should this check be moved to airpump.c?

10:22 am

Michael Garthwaite

DEN-14459: reverted code change due to code review comments.

Options
    • -0
    • +11
    /firmware/App/Controllers/AirTrap.c
10:21 am

Michael Garthwaite

Reverted. Thanks!

Reverted. Thanks!

10:11 am

Michael Garthwaite

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that...

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that to happen.

10:08 am

Sean Nash

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

10:06 am

Sean Nash

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

Tuesday 14 Feb 2023
4:43 pm

Michael Garthwaite , wbracken  (deleted user) and Sean Nash