hdfirmware

Clone Tools

Stats

Commits this week: 17
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Mar 2023
9:53 am

Michael Garthwaite

DEN-14689: message naming sync

Options
    • -1
    • +1
    /firmware/App/Controllers/FluidLeak.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/Modes/BloodPrime.c
    • -1
    • +1
    /firmware/App/Modes/ModePostTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -2
    • +2
    /firmware/App/Modes/ModeTreatment.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -2
    • +2
    /firmware/App/Modes/SelfTests.c
    • -1
    • +1
    /firmware/App/Modes/TreatmentRecirc.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.c
    • -13
    • +13
    /firmware/App/Services/SystemComm.c
    • -4
    • +4
    /firmware/App/Services/SystemCommMessages.c
9:41 am

Michael Garthwaite

DEN-14689: naming consistency pass.

Options
    • -4
    • +4
    /firmware/App/Services/SystemComm.c
    • -3
    • +2
    /firmware/App/Services/SystemCommMessages.c
8:23 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
8:23 am

Sean Nash

Fixed merge conflicts.

Options
    • -0
    • +9
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +0
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +2
    /firmware/App/Controllers/SyringePump.c
    • -9
    • +38
    /firmware/App/Modes/SelfTests.c
8:13 am

Sean Nash

DEN-13154: Update to handling of insufficient Heparin alarm per DEN-14814 and DEN-14287.

Options
    • -0
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -4
    • +33
    /firmware/App/Modes/SelfTests.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
Tuesday 28 Feb 2023
11:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

I don't think it's necessary - but I'm ok with either location for declaration. RESOLVED in CODE WALKTHROUGH.

I don't think it's necessary - but I'm ok with either location for declaration.
RESOLVED in CODE WALKTHROUGH.

9:38 am

jtaylor  (deleted user)

1. Style, and preference to keep loop control at the top, not buried in the state function. 2. Keep stack size for the state function more predictable. 3. I was considering unwrapping the state mac...

1. Style, and preference to keep loop control at the top, not buried in the state function.
2. Keep stack size for the state function more predictable.
3. I was considering unwrapping the state machine, starting with a separate pause state, that held for priming to advance to the proper state

Ultimately the simplest change may be limited to just this ifndef. No practical reason to move the declaration in that case.

9:24 am

jtaylor  (deleted user)

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

Monday 27 Feb 2023
4:01 pm

Dara Navaei

HD-DEN-14860_Recirculation Alarm 68 During High Flow Treatments
HD-DEN-14860_Recirculation Alarm 68 During High Flow Treatments
3:39 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Use higher percentage limit of depletion time alarm for faster dialysate flow. Linear interpolation between fast and slow reservoir fill speeds. Heater ON during reservoir transfer.

Options
    • -0
    • +5
    /firmware/App/Modes/SelfTests.c
    • -6
    • +55
    /firmware/App/Services/Reservoirs.c
3:39 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Use higher percentage limit of depletion time alarm for faster dialysate flow. Linear interpolation between fast and slow reservoir fill speeds. Heater ON during reservoir transfer.

Options
    • -0
    • +5
    /firmware/App/Modes/SelfTests.c
    • -6
    • +55
    /firmware/App/Services/Reservoirs.c
3:39 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Use higher percentage limit of depletion time alarm for faster dialysate flow. Linear interpolation between fast and slow reservoir fill speeds. Heater ON during reservoir transfer.

Options
    • -0
    • +5
    /firmware/App/Modes/SelfTests.c
    • -6
    • +55
    /firmware/App/Services/Reservoirs.c
11:40 am

Sean Nash

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide ...

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide what properties/persistence should be set.

11:37 am

Michael Garthwaite

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

11:30 am

Sean Nash

I thought the non-safety temp alarms had a large persistence. Now they have none?

I thought the non-safety temp alarms had a large persistence. Now they have none?

11:27 am

Sean Nash

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

11:03 am

Sean Nash

Why move this?

Why move this?

10:59 am

Sean Nash

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

10:51 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:51 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:36 am

Sean Nash

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structur...

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structures to 1 byte (8-bit) alignment.

10:30 am

Michael Garthwaite

Can you clarify? Is U08 no longer the size of 1 byte?

Can you clarify? Is U08 no longer the size of 1 byte?

10:23 am

Sean Nash

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

10:23 am

Sean Nash

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

10:21 am

Sean Nash

Remove 2 blank lines.

Remove 2 blank lines.

10:18 am

Sean Nash

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

10:13 am

Sean Nash

2 lines appropriate around banner separators like this.

2 lines appropriate around banner separators like this.

10:09 am

Sean Nash

Friday 24 Feb 2023
10:48 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h